You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by jm...@apache.org on 2006/12/20 08:58:42 UTC
svn commit: r488947 - in /incubator/tuscany/java/sca/kernel/api/src:
main/java/org/apache/tuscany/api/ test/java/org/apache/tuscany/api/
Author: jmarino
Date: Tue Dec 19 23:58:41 2006
New Revision: 488947
URL: http://svn.apache.org/viewvc?view=rev&rev=488947
Log:
make context names immutable
Modified:
incubator/tuscany/java/sca/kernel/api/src/main/java/org/apache/tuscany/api/TuscanyException.java
incubator/tuscany/java/sca/kernel/api/src/main/java/org/apache/tuscany/api/TuscanyRuntimeException.java
incubator/tuscany/java/sca/kernel/api/src/test/java/org/apache/tuscany/api/TuscanyExceptionTestCase.java
incubator/tuscany/java/sca/kernel/api/src/test/java/org/apache/tuscany/api/TuscanyRuntimeExceptionTestCase.java
Modified: incubator/tuscany/java/sca/kernel/api/src/main/java/org/apache/tuscany/api/TuscanyException.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/api/src/main/java/org/apache/tuscany/api/TuscanyException.java?view=diff&rev=488947&r1=488946&r2=488947
==============================================================================
--- incubator/tuscany/java/sca/kernel/api/src/main/java/org/apache/tuscany/api/TuscanyException.java (original)
+++ incubator/tuscany/java/sca/kernel/api/src/main/java/org/apache/tuscany/api/TuscanyException.java Tue Dec 19 23:58:41 2006
@@ -20,6 +20,7 @@
import java.util.ArrayList;
import java.util.List;
+import java.util.Collections;
import java.io.PrintWriter;
/**
@@ -111,7 +112,7 @@
if (contextStack == null) {
contextStack = new ArrayList<String>();
}
- return contextStack;
+ return Collections.unmodifiableList(contextStack);
}
/**
Modified: incubator/tuscany/java/sca/kernel/api/src/main/java/org/apache/tuscany/api/TuscanyRuntimeException.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/api/src/main/java/org/apache/tuscany/api/TuscanyRuntimeException.java?view=diff&rev=488947&r1=488946&r2=488947
==============================================================================
--- incubator/tuscany/java/sca/kernel/api/src/main/java/org/apache/tuscany/api/TuscanyRuntimeException.java (original)
+++ incubator/tuscany/java/sca/kernel/api/src/main/java/org/apache/tuscany/api/TuscanyRuntimeException.java Tue Dec 19 23:58:41 2006
@@ -20,6 +20,7 @@
import java.util.ArrayList;
import java.util.List;
+import java.util.Collections;
import java.io.PrintWriter;
/**
@@ -114,7 +115,7 @@
if (contextStack == null) {
contextStack = new ArrayList<String>();
}
- return contextStack;
+ return Collections.unmodifiableList(contextStack);
}
/**
Modified: incubator/tuscany/java/sca/kernel/api/src/test/java/org/apache/tuscany/api/TuscanyExceptionTestCase.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/api/src/test/java/org/apache/tuscany/api/TuscanyExceptionTestCase.java?view=diff&rev=488947&r1=488946&r2=488947
==============================================================================
--- incubator/tuscany/java/sca/kernel/api/src/test/java/org/apache/tuscany/api/TuscanyExceptionTestCase.java (original)
+++ incubator/tuscany/java/sca/kernel/api/src/test/java/org/apache/tuscany/api/TuscanyExceptionTestCase.java Tue Dec 19 23:58:41 2006
@@ -128,6 +128,16 @@
e.getMessage();
}
+ public void testImmutableContextNames() {
+ TuscanyException e = new DummyException("message", "foo");
+ try {
+ e.returnContextNames().add("foo");
+ fail();
+ } catch (UnsupportedOperationException e1) {
+ // expected
+ }
+ }
+
public static class DummyException extends TuscanyException {
Modified: incubator/tuscany/java/sca/kernel/api/src/test/java/org/apache/tuscany/api/TuscanyRuntimeExceptionTestCase.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/kernel/api/src/test/java/org/apache/tuscany/api/TuscanyRuntimeExceptionTestCase.java?view=diff&rev=488947&r1=488946&r2=488947
==============================================================================
--- incubator/tuscany/java/sca/kernel/api/src/test/java/org/apache/tuscany/api/TuscanyRuntimeExceptionTestCase.java (original)
+++ incubator/tuscany/java/sca/kernel/api/src/test/java/org/apache/tuscany/api/TuscanyRuntimeExceptionTestCase.java Tue Dec 19 23:58:41 2006
@@ -109,6 +109,16 @@
assertEquals("Message", writer.toString());
}
+ public void testImmutableContextNames() {
+ TuscanyRuntimeException e = new DummyException("message", "foo");
+ try {
+ e.returnContextNames().add("foo");
+ fail();
+ } catch (UnsupportedOperationException e1) {
+ // expected
+ }
+ }
+
public static class DummyException extends TuscanyRuntimeException {
public DummyException() {
}
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-commits-help@ws.apache.org