You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Daniel Pravat <dp...@outlook.com> on 2016/04/02 08:35:35 UTC
Review Request 45614: Windows: Implemented os::close for Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45614/
-----------------------------------------------------------
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.
Repository: mesos
Description
-------
Windows: Implemented os::close for Windows.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os/close.hpp 1c912c3edc815e7e0b1a562286279897d773a516
3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/close.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/close.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp ee13d12fcffcd564c7ded2d2f541d7bbdf6633c1
Diff: https://reviews.apache.org/r/45614/diff/
Testing
-------
OSX: make check
Thanks,
Daniel Pravat
Re: Review Request 45614: Windows: Implemented os::close for Windows.
Posted by Alex Naparu <al...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45614/#review128554
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/close.hpp (line 29)
<https://reviews.apache.org/r/45614/#comment191990>
`return ErrnoError()` if this fails? Same for ::closesocket().
- Alex Naparu
On April 2, 2016, 6:35 a.m., Daniel Pravat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45614/
> -----------------------------------------------------------
>
> (Updated April 2, 2016, 6:35 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Implemented os::close for Windows.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/close.hpp 1c912c3edc815e7e0b1a562286279897d773a516
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/close.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/close.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp ee13d12fcffcd564c7ded2d2f541d7bbdf6633c1
>
> Diff: https://reviews.apache.org/r/45614/diff/
>
>
> Testing
> -------
>
> OSX: make check
>
>
> Thanks,
>
> Daniel Pravat
>
>
Re: Review Request 45614: Windows: Implemented os::close for Windows.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45614/#review128742
-----------------------------------------------------------
Bad patch!
Reviews applied: [45614]
Failed command: ./support/apply-review.sh -n -r 45614
Error:
2016-04-13 20:50:38 URL:https://reviews.apache.org/r/45614/diff/raw/ [4160/4160] -> "45614.patch" [1]
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/os/close.hpp:14
error: 3rdparty/libprocess/3rdparty/stout/include/stout/os/close.hpp: patch does not apply
error: 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/close.hpp: already exists in index
error: 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/close.hpp: already exists in index
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp:339
error: 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp: patch does not apply
Full log: https://builds.apache.org/job/mesos-reviewbot/12509/console
- Mesos ReviewBot
On April 13, 2016, 6:21 p.m., Daniel Pravat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45614/
> -----------------------------------------------------------
>
> (Updated April 13, 2016, 6:21 p.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Implemented os::close for Windows.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/close.hpp 1c912c3edc815e7e0b1a562286279897d773a516
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/close.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/close.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp ee13d12fcffcd564c7ded2d2f541d7bbdf6633c1
>
> Diff: https://reviews.apache.org/r/45614/diff/
>
>
> Testing
> -------
>
> OSX: make check
>
>
> Thanks,
>
> Daniel Pravat
>
>
Re: Review Request 45614: Windows: Implemented os::close for Windows.
Posted by Daniel Pravat <dp...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45614/
-----------------------------------------------------------
(Updated April 13, 2016, 6:21 p.m.)
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.
Changes
-------
Removing discarded review from "depends on" field -- @vinodkone
Repository: mesos
Description
-------
Windows: Implemented os::close for Windows.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os/close.hpp 1c912c3edc815e7e0b1a562286279897d773a516
3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/close.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/close.hpp PRE-CREATION
3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp ee13d12fcffcd564c7ded2d2f541d7bbdf6633c1
Diff: https://reviews.apache.org/r/45614/diff/
Testing
-------
OSX: make check
Thanks,
Daniel Pravat
Re: Review Request 45614: Windows: Implemented os::close for Windows.
Posted by Alex Naparu <al...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45614/#review128556
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Naparu
On April 2, 2016, 6:35 a.m., Daniel Pravat wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45614/
> -----------------------------------------------------------
>
> (Updated April 2, 2016, 6:35 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Implemented os::close for Windows.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/close.hpp 1c912c3edc815e7e0b1a562286279897d773a516
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/close.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/close.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp ee13d12fcffcd564c7ded2d2f541d7bbdf6633c1
>
> Diff: https://reviews.apache.org/r/45614/diff/
>
>
> Testing
> -------
>
> OSX: make check
>
>
> Thanks,
>
> Daniel Pravat
>
>