You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/12 19:54:02 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #12170: Added a second example for TaskFlow API

kaxil commented on a change in pull request #12170:
URL: https://github.com/apache/airflow/pull/12170#discussion_r556042397



##########
File path: airflow/example_dags/tutorial_xcom_pandas.py
##########
@@ -0,0 +1,149 @@
+#

Review comment:
       Any suggestion on where this file should live @turbaszek?
   
   It can stay here too -- If we decide to keep it here, we need to apply the following diff as one of the tests is failing:
   
   ```diff
   diff --git a/tests/jobs/test_scheduler_job.py b/tests/jobs/test_scheduler_job.py
   index da27016a0..f8b6f3811 100644
   --- a/tests/jobs/test_scheduler_job.py
   +++ b/tests/jobs/test_scheduler_job.py
   @@ -3235,6 +3235,7 @@ class TestSchedulerJob(unittest.TestCase):
   
            ignored_files = {
                'helper.py',
   +            'tutorial_xcom_pandas.py',
            }
            example_dag_folder = airflow.example_dags.__path__[0]
            for root, _, files in os.walk(example_dag_folder):  # pylint: disable=too-many-nested-blocks
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org