You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by James Anderson <an...@gmail.com> on 2013/10/08 22:46:37 UTC

Review Request 14542: Review of SQOOP-1213

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14542/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1213
    https://issues.apache.org/jira/browse/SQOOP-1213


Repository: sqoop-trunk


Description
-------

In order to support reading password files from Amazon S3, instantiate the FileSystem object with the appropriate URI based on the provided path.


Diffs
-----

  src/java/org/apache/sqoop/util/CredentialsUtil.java 2d88bd3 

Diff: https://reviews.apache.org/r/14542/diff/


Testing
-------


Thanks,

James Anderson

Re: Review Request 14542: Review of SQOOP-1213

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14542/#review26832
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On Oct. 9, 2013, 2:57 p.m., James Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14542/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2013, 2:57 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1213
>     https://issues.apache.org/jira/browse/SQOOP-1213
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> In order to support reading password files from Amazon S3, instantiate the FileSystem object with the appropriate URI based on the provided path.
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/util/CredentialsUtil.java 2d88bd3 
> 
> Diff: https://reviews.apache.org/r/14542/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> James Anderson
> 
>

Re: Review Request 14542: Review of SQOOP-1213

Posted by James Anderson <an...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14542/
-----------------------------------------------------------

(Updated Oct. 9, 2013, 2:57 p.m.)


Review request for Sqoop.


Changes
-------

Thanks for the feedback, Jarcec.  I've switched to using Path.getFileSystem(Configuration) as suggested.  An updated version of the patch is attached to the JIRA ticket and this review request.


Bugs: SQOOP-1213
    https://issues.apache.org/jira/browse/SQOOP-1213


Repository: sqoop-trunk


Description
-------

In order to support reading password files from Amazon S3, instantiate the FileSystem object with the appropriate URI based on the provided path.


Diffs (updated)
-----

  src/java/org/apache/sqoop/util/CredentialsUtil.java 2d88bd3 

Diff: https://reviews.apache.org/r/14542/diff/


Testing
-------


Thanks,

James Anderson

Re: Review Request 14542: Review of SQOOP-1213

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14542/#review26800
-----------------------------------------------------------


Hi James,
thank you very much for working on this JIRA! I do have one small comment:


src/java/org/apache/sqoop/util/CredentialsUtil.java
<https://reviews.apache.org/r/14542/#comment52149>

    I've noticed that we are using rather Path.getFileSystem(Configuration) then the FileSystem.get() API call in the rest of the Sqoop codebase. Do you think that we could change it to be consistent?


Jarcec

- Jarek Cecho


On Oct. 8, 2013, 8:46 p.m., James Anderson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14542/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2013, 8:46 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1213
>     https://issues.apache.org/jira/browse/SQOOP-1213
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> In order to support reading password files from Amazon S3, instantiate the FileSystem object with the appropriate URI based on the provided path.
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/util/CredentialsUtil.java 2d88bd3 
> 
> Diff: https://reviews.apache.org/r/14542/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> James Anderson
> 
>