[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #961: impl GETEX

[GitBox <gi...@apache.org>]

PragmaTwice commented on code in PR #961:
URL: https://github.com/apache/incubator-kvrocks/pull/961#discussion_r990770527


##########
src/redis_cmd.cc:
##########
@@ -318,6 +380,48 @@ class CommandGet : public Commander {
   }
 };
 
+class CommandGetEx : public Commander {
+public:
+    Status Parse(const std::vector<std::string> &args) override {
+        if (std::find_if(args.begin(), args.end(), [](const std::string& str) -> bool {

Review Comment:
   I think it is more like a workaround rather than a good solution, as you first check whether there are non-exist options and then use  ParseTtlHelper which is designed for SET.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org