You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/08/08 07:27:11 UTC
[GitHub] [thrift] longzhiri opened a new pull request #2214: THRIFT-5262 Fix a encoding struct bug in the compact protocol implementation to lua
longzhiri opened a new pull request #2214:
URL: https://github.com/apache/thrift/pull/2214
Client:lua
<!-- Explain the changes in the pull request below: -->
code in lib/lua/TCompactProtocol.lua as follow:
```lua
function TCompactProtocol:writeStructBegin(name)
self.lastFieldIndex = self.lastFieldIndex + 1
self.lastField[self.lastFieldIndex] = self.lastFieldId
self.lastFieldId = 0
end
```
the lastFieldId is saved into the new lastFieldIndex pos and then is restored mistakenly later.
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G closed pull request #2214: THRIFT-5262 Fix a encoding struct bug in the compact protocol implementation to lua
Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2214:
URL: https://github.com/apache/thrift/pull/2214
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org