[GitHub] [brooklyn-ui] algairim commented on a change in pull request #216: Generate the catalog url

[GitBox <gi...@apache.org>]

algairim commented on a change in pull request #216:
URL: https://github.com/apache/brooklyn-ui/pull/216#discussion_r648380810



##########
File path: ui-modules/blueprint-composer/app/components/catalog-saver/catalog-saver.modal.template.html
##########
@@ -122,7 +122,7 @@ <h3>You're all set!</h3>
             <p>What would you like to do next?</p>
             <button class="btn btn-default btn-block" ng-click="$dismiss('Continue editing')">Continue to edit this blueprint</button>
             <button class="btn btn-info btn-block" ng-click="$close(REASONS.new)">Create a new blueprint</button>
-            <a class="btn btn-primary btn-block" ng-href="/brooklyn-ui-catalog/#!/bundles/catalog-bom-{{catalogBundleId}}/{{config.version}}/types/{{catalogBundleBase}}/{{config.version}}">View in catalog</a>
+            <a class="btn btn-primary btn-block" ng-href="{{getCatalogURL()}}">View in catalog</a>

Review comment:
       No need to how this button if URL is not available or not valid, consider `ng-if` to hide it until it URL is valid, or at least disable.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org