You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "pandaapo (via GitHub)" <gi...@apache.org> on 2023/05/07 13:35:01 UTC
[GitHub] [eventmesh] pandaapo opened a new pull request, #3882: [ISSUE #3879]Logger of slf4j does not work in eventmesh-common module
pandaapo opened a new pull request, #3882:
URL: https://github.com/apache/eventmesh/pull/3882
Fixes #3879.
### Motivation
The object of `org.slf4j.Logger` can not execute no matter `log.info`, `log.error` and so on. Includes the test code.
### Modifications
Add log4j2.xml to eventmesh-common module
### Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #3879]Logger of slf4j does not work in eventmesh-common test module (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #3882:
URL: https://github.com/apache/eventmesh/pull/3882#issuecomment-1885096399
Can we only add a xml configuration file under this module? This PR https://github.com/apache/eventmesh/pull/4719 proposes an alternative way to manage the Slf4j dependency, and let's looking forward to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #3879]Logger of slf4j does not work in eventmesh-common test module (eventmesh)
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo closed pull request #3882: [ISSUE #3879]Logger of slf4j does not work in eventmesh-common test module
URL: https://github.com/apache/eventmesh/pull/3882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3882: [ISSUE #3879]Logger of slf4j does not work in eventmesh-common test module
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3882:
URL: https://github.com/apache/eventmesh/pull/3882#issuecomment-1539604493
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3882?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3882](https://app.codecov.io/gh/apache/eventmesh/pull/3882?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7dcee91) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/d976bbf635b7f4bcdc032b1af5da175b6246e4b3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d976bbf) will **increase** coverage by `0.01%`.
> The diff coverage is `2.08%`.
> :exclamation: Current head 7dcee91 differs from pull request most recent head fc09233. Consider uploading reports for the commit fc09233 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3882 +/- ##
============================================
+ Coverage 13.91% 13.93% +0.01%
Complexity 1291 1291
============================================
Files 572 570 -2
Lines 28888 28843 -45
Branches 2816 2810 -6
============================================
- Hits 4019 4018 -1
+ Misses 24496 24450 -46
- Partials 373 375 +2
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3882?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/eventmesh/common/EventMeshThreadFactory.java](https://app.codecov.io/gh/apache/eventmesh/pull/3882?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9FdmVudE1lc2hUaHJlYWRGYWN0b3J5LmphdmE=) | `69.56% <ø> (ø)` | |
| [.../eventmesh/runtime/core/protocol/RetryContext.java](https://app.codecov.io/gh/apache/eventmesh/pull/3882?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvUmV0cnlDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ore/protocol/grpc/producer/SendMessageContext.java](https://app.codecov.io/gh/apache/eventmesh/pull/3882?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9wcm9kdWNlci9TZW5kTWVzc2FnZUNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...e/core/protocol/grpc/push/AbstractPushRequest.java](https://app.codecov.io/gh/apache/eventmesh/pull/3882?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9wdXNoL0Fic3RyYWN0UHVzaFJlcXVlc3QuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../runtime/core/protocol/grpc/retry/GrpcRetryer.java](https://app.codecov.io/gh/apache/eventmesh/pull/3882?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9yZXRyeS9HcnBjUmV0cnllci5qYXZh) | `0.00% <ø> (ø)` | |
| [...ore/protocol/http/producer/SendMessageContext.java](https://app.codecov.io/gh/apache/eventmesh/pull/3882?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9kdWNlci9TZW5kTWVzc2FnZUNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...re/protocol/http/push/AbstractHTTPPushRequest.java](https://app.codecov.io/gh/apache/eventmesh/pull/3882?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wdXNoL0Fic3RyYWN0SFRUUFB1c2hSZXF1ZXN0LmphdmE=) | `0.00% <ø> (ø)` | |
| [.../core/protocol/http/push/AsyncHTTPPushRequest.java](https://app.codecov.io/gh/apache/eventmesh/pull/3882?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wdXNoL0FzeW5jSFRUUFB1c2hSZXF1ZXN0LmphdmE=) | `0.00% <ø> (ø)` | |
| [.../runtime/core/protocol/http/retry/HttpRetryer.java](https://app.codecov.io/gh/apache/eventmesh/pull/3882?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9yZXRyeS9IdHRwUmV0cnllci5qYXZh) | `0.00% <ø> (ø)` | |
| [...time/core/protocol/tcp/client/session/Session.java](https://app.codecov.io/gh/apache/eventmesh/pull/3882?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9zZXNzaW9uL1Nlc3Npb24uamF2YQ==) | `2.40% <0.00%> (+0.28%)` | :arrow_up: |
| ... and [9 more](https://app.codecov.io/gh/apache/eventmesh/pull/3882?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [10 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3882/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org