You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/11/01 04:26:39 UTC
[GitHub] [incubator-doris] xinyiZzz opened a new pull request #6977: [Function] add BE bitmap function sub_bitmap
xinyiZzz opened a new pull request #6977:
URL: https://github.com/apache/incubator-doris/pull/6977
## Proposed changes
Starting from the offset position, intercept the specified limit bitmap elements and return a bitmap subset.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on (Fix #6875 ) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #6977: [Function] add BE bitmap function sub_bitmap
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #6977:
URL: https://github.com/apache/incubator-doris/pull/6977#discussion_r740308333
##########
File path: be/src/exprs/bitmap_function.h
##########
@@ -99,6 +99,8 @@ class BitmapFunctions {
static BigIntVal bitmap_max(FunctionContext* ctx, const StringVal& str);
static StringVal bitmap_subset_in_range(FunctionContext* ctx, const StringVal& src,
const BigIntVal& range_start, const BigIntVal& range_end);
+ static StringVal sub_bitmap(FunctionContext* ctx, const StringVal& src,
Review comment:
Without implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6977: [Function] add BE bitmap function sub_bitmap
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #6977:
URL: https://github.com/apache/incubator-doris/pull/6977#issuecomment-961881620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz commented on a change in pull request #6977: [Function] add BE bitmap function sub_bitmap
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on a change in pull request #6977:
URL: https://github.com/apache/incubator-doris/pull/6977#discussion_r740326776
##########
File path: be/src/exprs/bitmap_function.h
##########
@@ -99,6 +99,8 @@ class BitmapFunctions {
static BigIntVal bitmap_max(FunctionContext* ctx, const StringVal& str);
static StringVal bitmap_subset_in_range(FunctionContext* ctx, const StringVal& src,
const BigIntVal& range_start, const BigIntVal& range_end);
+ static StringVal sub_bitmap(FunctionContext* ctx, const StringVal& src,
Review comment:
bitmap_function.cpp have implementation
After resolving the conflict, format is out of order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz commented on a change in pull request #6977: [Function] add BE bitmap function sub_bitmap
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on a change in pull request #6977:
URL: https://github.com/apache/incubator-doris/pull/6977#discussion_r740326776
##########
File path: be/src/exprs/bitmap_function.h
##########
@@ -99,6 +99,8 @@ class BitmapFunctions {
static BigIntVal bitmap_max(FunctionContext* ctx, const StringVal& str);
static StringVal bitmap_subset_in_range(FunctionContext* ctx, const StringVal& src,
const BigIntVal& range_start, const BigIntVal& range_end);
+ static StringVal sub_bitmap(FunctionContext* ctx, const StringVal& src,
Review comment:
bitmap_function.cpp have implementation
After resolving the conflict, format is out of order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg merged pull request #6977: [Function] add BE bitmap function sub_bitmap
Posted by GitBox <gi...@apache.org>.
yangzhg merged pull request #6977:
URL: https://github.com/apache/incubator-doris/pull/6977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz commented on pull request #6977: [Function] add BE bitmap function sub_bitmap
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on pull request #6977:
URL: https://github.com/apache/incubator-doris/pull/6977#issuecomment-961596055
> Please solve the conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #6977: [Function] add BE bitmap function sub_bitmap
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #6977:
URL: https://github.com/apache/incubator-doris/pull/6977#issuecomment-957223077
Please solve the conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #6977: [Function] add BE bitmap function sub_bitmap
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #6977:
URL: https://github.com/apache/incubator-doris/pull/6977#issuecomment-957223077
Please solve the conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz removed a comment on pull request #6977: [Function] add BE bitmap function sub_bitmap
Posted by GitBox <gi...@apache.org>.
xinyiZzz removed a comment on pull request #6977:
URL: https://github.com/apache/incubator-doris/pull/6977#issuecomment-961596055
> Please solve the conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz removed a comment on pull request #6977: [Function] add BE bitmap function sub_bitmap
Posted by GitBox <gi...@apache.org>.
xinyiZzz removed a comment on pull request #6977:
URL: https://github.com/apache/incubator-doris/pull/6977#issuecomment-961596055
> Please solve the conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz commented on pull request #6977: [Function] add BE bitmap function sub_bitmap
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on pull request #6977:
URL: https://github.com/apache/incubator-doris/pull/6977#issuecomment-961597513
> Please solve the conflict
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #6977: [Function] add BE bitmap function sub_bitmap
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #6977:
URL: https://github.com/apache/incubator-doris/pull/6977#discussion_r740308333
##########
File path: be/src/exprs/bitmap_function.h
##########
@@ -99,6 +99,8 @@ class BitmapFunctions {
static BigIntVal bitmap_max(FunctionContext* ctx, const StringVal& str);
static StringVal bitmap_subset_in_range(FunctionContext* ctx, const StringVal& src,
const BigIntVal& range_start, const BigIntVal& range_end);
+ static StringVal sub_bitmap(FunctionContext* ctx, const StringVal& src,
Review comment:
Without implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz closed pull request #6977: [Function] add BE bitmap function sub_bitmap
Posted by GitBox <gi...@apache.org>.
xinyiZzz closed pull request #6977:
URL: https://github.com/apache/incubator-doris/pull/6977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz closed pull request #6977: [Function] add BE bitmap function sub_bitmap
Posted by GitBox <gi...@apache.org>.
xinyiZzz closed pull request #6977:
URL: https://github.com/apache/incubator-doris/pull/6977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #6977: [Function] add BE bitmap function sub_bitmap
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #6977:
URL: https://github.com/apache/incubator-doris/pull/6977#issuecomment-957223077
Please solve the conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6977: [Function] add BE bitmap function sub_bitmap
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #6977:
URL: https://github.com/apache/incubator-doris/pull/6977#issuecomment-961881620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz closed pull request #6977: [Function] add BE bitmap function sub_bitmap
Posted by GitBox <gi...@apache.org>.
xinyiZzz closed pull request #6977:
URL: https://github.com/apache/incubator-doris/pull/6977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz removed a comment on pull request #6977: [Function] add BE bitmap function sub_bitmap
Posted by GitBox <gi...@apache.org>.
xinyiZzz removed a comment on pull request #6977:
URL: https://github.com/apache/incubator-doris/pull/6977#issuecomment-961596055
> Please solve the conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz commented on pull request #6977: [Function] add BE bitmap function sub_bitmap
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on pull request #6977:
URL: https://github.com/apache/incubator-doris/pull/6977#issuecomment-961596055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] xinyiZzz commented on pull request #6977: [Function] add BE bitmap function sub_bitmap
Posted by GitBox <gi...@apache.org>.
xinyiZzz commented on pull request #6977:
URL: https://github.com/apache/incubator-doris/pull/6977#issuecomment-961596055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org