You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by hl...@apache.org on 2008/04/02 03:16:29 UTC
svn commit: r643674 - in
/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry:
FieldValidator.java corelib/components/Select.java
Author: hlship
Date: Tue Apr 1 18:16:26 2008
New Revision: 643674
URL: http://svn.apache.org/viewvc?rev=643674&view=rev
Log:
TAPESTRY-2323: Select component does not generate client-side validation
Modified:
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/FieldValidator.java
tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/corelib/components/Select.java
Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/FieldValidator.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/FieldValidator.java?rev=643674&r1=643673&r2=643674&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/FieldValidator.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/FieldValidator.java Tue Apr 1 18:16:26 2008
@@ -36,7 +36,8 @@
/**
* Invokes {@link Validator#render(Field, Object, org.apache.tapestry.ioc.MessageFormatter, MarkupWriter,
* org.apache.tapestry.services.FormSupport)}. This is called at a point "inside" the tag, so that additional
- * attributes may be added.
+ * attributes may be added. In many cases, the underlying {@link org.apache.tapestry.Validator} may write
+ * client-side JavaScript to enforce the constraint as well.
*
* @param writer markup writer to direct output to.
* @see org.apache.tapestry.MarkupWriter#attributes(Object[])
Modified: tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/corelib/components/Select.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/corelib/components/Select.java?rev=643674&r1=643673&r2=643674&view=diff
==============================================================================
--- tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/corelib/components/Select.java (original)
+++ tapestry/tapestry5/trunk/tapestry-core/src/main/java/org/apache/tapestry/corelib/components/Select.java Tue Apr 1 18:16:26 2008
@@ -166,6 +166,8 @@
{
writer.element("select", "name", getControlName(), "id", getClientId());
+ _validate.render(writer);
+
_resources.renderInformalParameters(writer);
// Disabled is via a mixin