You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Zhang (JIRA)" <ji...@apache.org> on 2006/07/20 10:21:13 UTC

[jira] Created: (HARMONY-929) [classlib][nio]FileChannel.transforTo can use system call to improve efficiency

[classlib][nio]FileChannel.transforTo can use system call to improve efficiency
-------------------------------------------------------------------------------

                 Key: HARMONY-929
                 URL: http://issues.apache.org/jira/browse/HARMONY-929
             Project: Harmony
          Issue Type: Improvement
          Components: Classlib
            Reporter: Andrew Zhang


Hello, 
    According to javadoc, the method transforTo is potentially much more efficient than a simple
loop that reads from this channel and writes to the target channel. But currently, Harmony use a simple loop. Use system call instead of the simple loop can be an improvement.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-929) [classlib][nio]FileChannel.transforTo can use system call to improve efficiency

Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-929?page=comments#action_12424037 ] 
            
Andrew Zhang commented on HARMONY-929:
--------------------------------------

Hi Paulex,

The fix looks good, many thanks!

Best regards,
Andrew

> [classlib][nio]FileChannel.transforTo can use system call to improve efficiency
> -------------------------------------------------------------------------------
>
>                 Key: HARMONY-929
>                 URL: http://issues.apache.org/jira/browse/HARMONY-929
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Andrew Zhang
>         Assigned To: Paulex Yang
>         Attachments: 01.luni.diff, 02.nio.diff
>
>
> Hello, 
>     According to javadoc, the method transforTo is potentially much more efficient than a simple
> loop that reads from this channel and writes to the target channel. But currently, Harmony use a simple loop. Use system call instead of the simple loop can be an improvement.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (HARMONY-929) [classlib][nio]FileChannel.transforTo can use system call to improve efficiency

Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-929?page=all ]

Paulex Yang reassigned HARMONY-929:
-----------------------------------

    Assignee: Paulex Yang

> [classlib][nio]FileChannel.transforTo can use system call to improve efficiency
> -------------------------------------------------------------------------------
>
>                 Key: HARMONY-929
>                 URL: http://issues.apache.org/jira/browse/HARMONY-929
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Andrew Zhang
>         Assigned To: Paulex Yang
>         Attachments: 01.luni.diff, 02.nio.diff
>
>
> Hello, 
>     According to javadoc, the method transforTo is potentially much more efficient than a simple
> loop that reads from this channel and writes to the target channel. But currently, Harmony use a simple loop. Use system call instead of the simple loop can be an improvement.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (HARMONY-929) [classlib][nio]FileChannel.transforTo can use system call to improve efficiency

Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-929?page=all ]

Paulex Yang closed HARMONY-929.
-------------------------------


Verified by Andrew.

> [classlib][nio]FileChannel.transforTo can use system call to improve efficiency
> -------------------------------------------------------------------------------
>
>                 Key: HARMONY-929
>                 URL: http://issues.apache.org/jira/browse/HARMONY-929
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Andrew Zhang
>         Assigned To: Paulex Yang
>         Attachments: 01.luni.diff, 02.nio.diff
>
>
> Hello, 
>     According to javadoc, the method transforTo is potentially much more efficient than a simple
> loop that reads from this channel and writes to the target channel. But currently, Harmony use a simple loop. Use system call instead of the simple loop can be an improvement.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (HARMONY-929) [classlib][nio]FileChannel.transforTo can use system call to improve efficiency

Posted by "Paulex Yang (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-929?page=all ]

Paulex Yang resolved HARMONY-929.
---------------------------------

    Resolution: Fixed

Andrew, patch applied at revision r423857 and r423858, thanks a lot for this enhancement, please verify that the problem is fully fixed as you expected.

> [classlib][nio]FileChannel.transforTo can use system call to improve efficiency
> -------------------------------------------------------------------------------
>
>                 Key: HARMONY-929
>                 URL: http://issues.apache.org/jira/browse/HARMONY-929
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Andrew Zhang
>         Assigned To: Paulex Yang
>         Attachments: 01.luni.diff, 02.nio.diff
>
>
> Hello, 
>     According to javadoc, the method transforTo is potentially much more efficient than a simple
> loop that reads from this channel and writes to the target channel. But currently, Harmony use a simple loop. Use system call instead of the simple loop can be an improvement.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-929) [classlib][nio]FileChannel.transforTo can use system call to improve efficiency

Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-929?page=all ]

Andrew Zhang updated HARMONY-929:
---------------------------------

    Attachment: 01.luni.diff
                02.nio.diff

Hello,

    Would you please try my patch?

Thanks!

Best regards,
Andrew

> [classlib][nio]FileChannel.transforTo can use system call to improve efficiency
> -------------------------------------------------------------------------------
>
>                 Key: HARMONY-929
>                 URL: http://issues.apache.org/jira/browse/HARMONY-929
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Andrew Zhang
>         Attachments: 01.luni.diff, 02.nio.diff
>
>
> Hello, 
>     According to javadoc, the method transforTo is potentially much more efficient than a simple
> loop that reads from this channel and writes to the target channel. But currently, Harmony use a simple loop. Use system call instead of the simple loop can be an improvement.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira