You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "neilcsmith-net (via GitHub)" <gi...@apache.org> on 2023/05/03 09:38:31 UTC
[GitHub] [netbeans] neilcsmith-net opened a new pull request, #5912: Fix unit test on single file being reported as integration test GH4587
neilcsmith-net opened a new pull request, #5912:
URL: https://github.com/apache/netbeans/pull/5912
Fix unit test on single file being reported as integration test in some cases.
Change isIntegrationTestTarget to use extractFileObjectsfromLookup() as missing DataObject conversion, and make sure an empty list returns false (due to use of allMatch on empty stream).
Fixes #4587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5912: Fix unit test on single file being reported as integration test GH4587
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5912:
URL: https://github.com/apache/netbeans/pull/5912#issuecomment-1532741753
(adding the triage label and removing it again fixes the problem for me when github doesn't want to link the issue with the PR. Worked on two PRs already.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5912: Fix unit test on single file being reported as integration test GH4587
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5912:
URL: https://github.com/apache/netbeans/pull/5912#issuecomment-1532750422
@mbien Thanks. I wondered about the extra labelling! :smile: Just adding the `Fixes XXX` text in the description or commit should have the same effect, although it would be good if the sidebar picked that up. And anything merging into `delivery` needs manual closing anyway as it's not the default branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #5912: Fix unit test on single file being reported as integration test GH4587
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net merged PR #5912:
URL: https://github.com/apache/netbeans/pull/5912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists