You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by on...@apache.org on 2017/01/19 08:51:04 UTC

svn commit: r1779433 - /poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/SXSSFITestDataProvider.java

Author: onealj
Date: Thu Jan 19 08:51:04 2017
New Revision: 1779433

URL: http://svn.apache.org/viewvc?rev=1779433&view=rev
Log:
bug 60601: allow SXSSFITestDataProvider.writeOutAndReadBack(Workbook wb) to work on SXSSFWorkbooks and XSSFWorkbooks

Modified:
    poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/SXSSFITestDataProvider.java

Modified: poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/SXSSFITestDataProvider.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/SXSSFITestDataProvider.java?rev=1779433&r1=1779432&r2=1779433&view=diff
==============================================================================
--- poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/SXSSFITestDataProvider.java (original)
+++ poi/trunk/src/ooxml/testcases/org/apache/poi/xssf/SXSSFITestDataProvider.java Thu Jan 19 08:51:04 2017
@@ -64,7 +64,10 @@ public final class SXSSFITestDataProvide
      */
     @Override
     public XSSFWorkbook writeOutAndReadBack(Workbook wb) {
-        if(!(wb instanceof SXSSFWorkbook)) {
+        // wb is usually an SXSSFWorkbook, but must also work on an XSSFWorkbook
+        // since workbooks must be able to be written out and read back
+        // several times in succession
+        if(!(wb instanceof SXSSFWorkbook || wb instanceof XSSFWorkbook)) {
             throw new IllegalArgumentException("Expected an instance of SXSSFWorkbook");
         }
 



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org