You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/06/11 23:16:51 UTC

[PR] Fix CI tests by disabling AWS metadata [datafusion]

alamb opened a new pull request, #16381:
URL: https://github.com/apache/datafusion/pull/16381

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   - Closes https://github.com/apache/datafusion/issues/16378
   
   ## Rationale for this change
   The way credentials are resolved on AWS builders has changed and now the tests seem to try to get access to credentials which are not available
   
   ## What changes are included in this PR?
   Disable test name resolution
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   ## Are these changes tested?
   
   I am testing manually on an EC2 instance
   
   ## Are there any user-facing changes?
   
   no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] Fix CI tests by disabling AWS metadata [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed pull request #16381: Fix CI tests by disabling AWS metadata
URL: https://github.com/apache/datafusion/pull/16381


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] Fix CI tests by disabling AWS metadata [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #16381:
URL: https://github.com/apache/datafusion/pull/16381#discussion_r2141267569


##########
.github/workflows/extended.yml:
##########
@@ -100,7 +100,10 @@ jobs:
           df -h
       - name: Run tests (excluding doctests)
         env:
-          RUST_BACKTRACE: 1
+          # Disable AWS EC2 metadata service which does not work in
+          # GitHub Actions container environment.
+          # See https://github.com/apache/datafusion/issues/16378
+          AWS_EC2_METADATA_DISABLED: 1

Review Comment:
   When I tried to reproduce this error on an AWS instance I got the following error (which is different than we are seeing on CI):
   
   ```
   thread 'object_storage::tests::s3_object_store_builder_default' panicked at datafusion-cli/src/object_storage.rs:584:9:
   assertion `left == right` failed
     left: Some("us-west-2")
    right: None
   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
   
   ```
   
   I have another idea



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [PR] Fix CI tests by disabling AWS metadata [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #16381:
URL: https://github.com/apache/datafusion/pull/16381#discussion_r2141267569


##########
.github/workflows/extended.yml:
##########
@@ -100,7 +100,10 @@ jobs:
           df -h
       - name: Run tests (excluding doctests)
         env:
-          RUST_BACKTRACE: 1
+          # Disable AWS EC2 metadata service which does not work in
+          # GitHub Actions container environment.
+          # See https://github.com/apache/datafusion/issues/16378
+          AWS_EC2_METADATA_DISABLED: 1

Review Comment:
   When I tried to reproduce this error on an AWS instance I got the following error:
   
   ```
   thread 'object_storage::tests::s3_object_store_builder_default' panicked at datafusion-cli/src/object_storage.rs:584:9:
   assertion `left == right` failed
     left: Some("us-west-2")
    right: None
   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org