You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by keval bhatt <kb...@apache.org> on 2019/10/23 06:58:29 UTC

Review Request 71653: ATLAS-3484 : Beta UI: Add more resize flexibility for sidebar

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71653/
-----------------------------------------------------------

Review request for atlas, Nixon Rodrigues and Sarath Subramanian.


Bugs: ATLAS-3484
    https://issues.apache.org/jira/browse/ATLAS-3484


Repository: atlas


Description
-------

Allows user to expand or collapse sidebar without any width restriction.


Diffs
-----

  dashboardv3/public/css/bootstrap-sidebar.css 1597d1829 
  dashboardv3/public/css/scss/leftsidebar.scss 734af6c8d 
  dashboardv3/public/css/scss/table.scss 06fb29b6e 
  dashboardv3/public/css/scss/theme.scss 59e8aef25 
  dashboardv3/public/js/utils/Helper.js 508b8a0f3 
  dashboardv3/public/js/views/search/SearchFilterBrowseLayoutView.js dca2a516b 
  dashboardv3/public/js/views/search/save/SaveModalLayoutView.js ac31a00e1 
  dashboardv3/public/js/views/search/tree/ClassificationTreeLayoutView.js 2022bf24a 
  dashboardv3/public/js/views/search/tree/CustomFilterTreeLayoutView.js 01c1a2ce2 
  dashboardv3/public/js/views/search/tree/EntityTreeLayoutView.js dfb2954ea 
  dashboardv3/public/js/views/search/tree/GlossaryTreeLayoutView.js 523d23e58 


Diff: https://reviews.apache.org/r/71653/diff/1/


Testing
-------

Done one round of sanity test


Thanks,

keval bhatt


Re: Review Request 71653: ATLAS-3484 : Beta UI: Add more resize flexibility for sidebar

Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71653/#review218365
-----------------------------------------------------------


Ship it!




Ship It!

- Sarath Subramanian


On Oct. 23, 2019, 6:28 a.m., keval bhatt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71653/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2019, 6:28 a.m.)
> 
> 
> Review request for atlas, Nixon Rodrigues and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3484
>     https://issues.apache.org/jira/browse/ATLAS-3484
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Allows user to expand or collapse sidebar without any width restriction.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/css/scss/table.scss f14ebfb0a 
>   dashboardv2/public/js/utils/Overrides.js 61c95957d 
>   dashboardv2/public/js/views/entity/CreateEntityLayoutView.js 00f6d0e12 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js d82ed9750 
>   dashboardv3/public/css/bootstrap-sidebar.css 1597d1829 
>   dashboardv3/public/css/scss/leftsidebar.scss 734af6c8d 
>   dashboardv3/public/css/scss/table.scss 06fb29b6e 
>   dashboardv3/public/css/scss/theme.scss 59e8aef25 
>   dashboardv3/public/js/utils/Helper.js 508b8a0f3 
>   dashboardv3/public/js/utils/Overrides.js 61c95957d 
>   dashboardv3/public/js/views/entity/CreateEntityLayoutView.js d32784858 
>   dashboardv3/public/js/views/search/SearchFilterBrowseLayoutView.js dca2a516b 
>   dashboardv3/public/js/views/search/SearchResultLayoutView.js cb0c6be0c 
>   dashboardv3/public/js/views/search/save/SaveModalLayoutView.js ac31a00e1 
>   dashboardv3/public/js/views/search/tree/ClassificationTreeLayoutView.js 2022bf24a 
>   dashboardv3/public/js/views/search/tree/CustomFilterTreeLayoutView.js 01c1a2ce2 
>   dashboardv3/public/js/views/search/tree/EntityTreeLayoutView.js dfb2954ea 
>   dashboardv3/public/js/views/search/tree/GlossaryTreeLayoutView.js 523d23e58 
> 
> 
> Diff: https://reviews.apache.org/r/71653/diff/2/
> 
> 
> Testing
> -------
> 
> Done one round of sanity test
> 
> 
> Thanks,
> 
> keval bhatt
> 
>


Re: Review Request 71653: ATLAS-3484 : Beta UI: Add more resize flexibility for sidebar

Posted by keval bhatt <kb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71653/
-----------------------------------------------------------

(Updated Oct. 23, 2019, 1:28 p.m.)


Review request for atlas, Nixon Rodrigues and Sarath Subramanian.


Bugs: ATLAS-3484
    https://issues.apache.org/jira/browse/ATLAS-3484


Repository: atlas


Description
-------

Allows user to expand or collapse sidebar without any width restriction.


Diffs (updated)
-----

  dashboardv2/public/css/scss/table.scss f14ebfb0a 
  dashboardv2/public/js/utils/Overrides.js 61c95957d 
  dashboardv2/public/js/views/entity/CreateEntityLayoutView.js 00f6d0e12 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js d82ed9750 
  dashboardv3/public/css/bootstrap-sidebar.css 1597d1829 
  dashboardv3/public/css/scss/leftsidebar.scss 734af6c8d 
  dashboardv3/public/css/scss/table.scss 06fb29b6e 
  dashboardv3/public/css/scss/theme.scss 59e8aef25 
  dashboardv3/public/js/utils/Helper.js 508b8a0f3 
  dashboardv3/public/js/utils/Overrides.js 61c95957d 
  dashboardv3/public/js/views/entity/CreateEntityLayoutView.js d32784858 
  dashboardv3/public/js/views/search/SearchFilterBrowseLayoutView.js dca2a516b 
  dashboardv3/public/js/views/search/SearchResultLayoutView.js cb0c6be0c 
  dashboardv3/public/js/views/search/save/SaveModalLayoutView.js ac31a00e1 
  dashboardv3/public/js/views/search/tree/ClassificationTreeLayoutView.js 2022bf24a 
  dashboardv3/public/js/views/search/tree/CustomFilterTreeLayoutView.js 01c1a2ce2 
  dashboardv3/public/js/views/search/tree/EntityTreeLayoutView.js dfb2954ea 
  dashboardv3/public/js/views/search/tree/GlossaryTreeLayoutView.js 523d23e58 


Diff: https://reviews.apache.org/r/71653/diff/2/

Changes: https://reviews.apache.org/r/71653/diff/1-2/


Testing
-------

Done one round of sanity test


Thanks,

keval bhatt