You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/08/07 14:52:04 UTC
Review Request 37215: Use the system-wide AsyncExecutor for pubsub
events.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37215/
-----------------------------------------------------------
Review request for Aurora and Maxim Khutornenko.
Bugs: AURORA-1395
https://issues.apache.org/jira/browse/AURORA-1395
Repository: aurora
Description
-------
This should be the final missing piece for proper deferment of async work created in the scope of a transaction.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/app/AppModule.java 4cc11274313a15d34c572b70e2ed218c4ea1197a
src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 8416ea0fa59ef316d7e75cec686204430fb3aa71
src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java ccecfdba20783dd4b99203b2f93d231adb9777b0
src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 23c2693f1dfd589043c60ab22e302fb81e62335d
src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 4c189c13c0b270e5bb7e6050b5314483c578fac9
src/test/java/org/apache/aurora/scheduler/reconciliation/KillRetryTest.java 957cbd09b714dcf38c3ed94608fee8bd054c06b4
src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImplTest.java 350ec6f3c6aa0526b484758a64165392c87842c4
src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java ba2edd8bd750e0caa1584768b50e4366cef33c52
Diff: https://reviews.apache.org/r/37215/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 37215: Use the system-wide AsyncExecutor for pubsub
events.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37215/#review94587
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Aug. 7, 2015, 12:52 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37215/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2015, 12:52 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-1395
> https://issues.apache.org/jira/browse/AURORA-1395
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This should be the final missing piece for proper deferment of async work created in the scope of a transaction.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/app/AppModule.java 4cc11274313a15d34c572b70e2ed218c4ea1197a
> src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 8416ea0fa59ef316d7e75cec686204430fb3aa71
> src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java ccecfdba20783dd4b99203b2f93d231adb9777b0
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 23c2693f1dfd589043c60ab22e302fb81e62335d
> src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 4c189c13c0b270e5bb7e6050b5314483c578fac9
> src/test/java/org/apache/aurora/scheduler/reconciliation/KillRetryTest.java 957cbd09b714dcf38c3ed94608fee8bd054c06b4
> src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImplTest.java 350ec6f3c6aa0526b484758a64165392c87842c4
> src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java ba2edd8bd750e0caa1584768b50e4366cef33c52
>
> Diff: https://reviews.apache.org/r/37215/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 37215: Use the system-wide AsyncExecutor for pubsub
events.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37215/#review94535
-----------------------------------------------------------
Ship it!
Master (8adc9bd) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Aug. 7, 2015, 12:52 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37215/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2015, 12:52 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-1395
> https://issues.apache.org/jira/browse/AURORA-1395
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This should be the final missing piece for proper deferment of async work created in the scope of a transaction.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/app/AppModule.java 4cc11274313a15d34c572b70e2ed218c4ea1197a
> src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 8416ea0fa59ef316d7e75cec686204430fb3aa71
> src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java ccecfdba20783dd4b99203b2f93d231adb9777b0
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 23c2693f1dfd589043c60ab22e302fb81e62335d
> src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 4c189c13c0b270e5bb7e6050b5314483c578fac9
> src/test/java/org/apache/aurora/scheduler/reconciliation/KillRetryTest.java 957cbd09b714dcf38c3ed94608fee8bd054c06b4
> src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImplTest.java 350ec6f3c6aa0526b484758a64165392c87842c4
> src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java ba2edd8bd750e0caa1584768b50e4366cef33c52
>
> Diff: https://reviews.apache.org/r/37215/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 37215: Use the system-wide AsyncExecutor for pubsub
events.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37215/#review94607
-----------------------------------------------------------
Ship it!
Master (cbc42c4) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Aug. 8, 2015, 1:06 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37215/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2015, 1:06 a.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Bugs: AURORA-1395
> https://issues.apache.org/jira/browse/AURORA-1395
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This should be the final missing piece for proper deferment of async work created in the scope of a transaction.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/app/AppModule.java 4cc11274313a15d34c572b70e2ed218c4ea1197a
> src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 8416ea0fa59ef316d7e75cec686204430fb3aa71
> src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java ccecfdba20783dd4b99203b2f93d231adb9777b0
> src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 8d8f8a26fe341713953cfc5897cf6744dfb48f05
> src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 4c189c13c0b270e5bb7e6050b5314483c578fac9
> src/test/java/org/apache/aurora/scheduler/reconciliation/KillRetryTest.java 957cbd09b714dcf38c3ed94608fee8bd054c06b4
> src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImplTest.java 492334ba4ef25d5dff2a141677e40a3db141c187
> src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java ba2edd8bd750e0caa1584768b50e4366cef33c52
>
> Diff: https://reviews.apache.org/r/37215/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 37215: Use the system-wide AsyncExecutor for pubsub
events.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37215/
-----------------------------------------------------------
(Updated Aug. 8, 2015, 1:06 a.m.)
Review request for Aurora and Maxim Khutornenko.
Changes
-------
Rebase.
Bugs: AURORA-1395
https://issues.apache.org/jira/browse/AURORA-1395
Repository: aurora
Description
-------
This should be the final missing piece for proper deferment of async work created in the scope of a transaction.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/app/AppModule.java 4cc11274313a15d34c572b70e2ed218c4ea1197a
src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 8416ea0fa59ef316d7e75cec686204430fb3aa71
src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java ccecfdba20783dd4b99203b2f93d231adb9777b0
src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 8d8f8a26fe341713953cfc5897cf6744dfb48f05
src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java 4c189c13c0b270e5bb7e6050b5314483c578fac9
src/test/java/org/apache/aurora/scheduler/reconciliation/KillRetryTest.java 957cbd09b714dcf38c3ed94608fee8bd054c06b4
src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImplTest.java 492334ba4ef25d5dff2a141677e40a3db141c187
src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java ba2edd8bd750e0caa1584768b50e4366cef33c52
Diff: https://reviews.apache.org/r/37215/diff/
Testing
-------
Thanks,
Bill Farner