You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/07/11 03:43:44 UTC
[GitHub] erisu commented on issue #465: CB-14201: (android) Removes Gradle property in-line command arguments…
erisu commented on issue #465: CB-14201: (android) Removes Gradle property in-line command arguments…
URL: https://github.com/apache/cordova-android/pull/465#issuecomment-404035534
@raphinesse
I created this PR to replace the previous PR #459.
As discusses in #459, it does feel better to remove the Gradle command line argument usage in-favor of the `gradle.properties` file. This also eliminates the idea or need for creating extra Cordova arguments for setting `jvmargs` or potential other Gradle property overrides.
The user can instead change the values in gradle.properties.
Please let me know what you think of this over the other PR.
Also, this PR is linked to a new ticket, https://issues.apache.org/jira/browse/CB-14201, as the previous ticket only focused on `jvmargs`. This PR will affect all Gradle properties that we current set. (`org.gradle.daemon`, `org.gradle.jvmargs`, `android.useDeprecatedNdk`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org