You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/17 13:07:21 UTC
[GitHub] [flink] matriv opened a new pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
matriv opened a new pull request #18381:
URL: https://github.com/apache/flink/pull/18381
The upcoming version to be released need to exist already in master so that
when the new release branch is created from master the version of the release
is already there.
Follows: #18340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
}, {
"hash" : "407dbd00b6169cf0df0667e76811d468356be63d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905",
"triggerID" : "407dbd00b6169cf0df0667e76811d468356be63d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa06744edb04bbfba64b233e4755ea0fb98977f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573)
* 407dbd00b6169cf0df0667e76811d468356be63d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
}, {
"hash" : "407dbd00b6169cf0df0667e76811d468356be63d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905",
"triggerID" : "407dbd00b6169cf0df0667e76811d468356be63d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa06744edb04bbfba64b233e4755ea0fb98977f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573)
* 407dbd00b6169cf0df0667e76811d468356be63d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
}, {
"hash" : "407dbd00b6169cf0df0667e76811d468356be63d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905",
"triggerID" : "407dbd00b6169cf0df0667e76811d468356be63d",
"triggerType" : "PUSH"
}, {
"hash" : "2fe465933260f527c7776a89b2016e558457e634",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29913",
"triggerID" : "2fe465933260f527c7776a89b2016e558457e634",
"triggerType" : "PUSH"
}, {
"hash" : "6ce750022ca8bfbf18e2df2eb496ad8fd63553ed",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6ce750022ca8bfbf18e2df2eb496ad8fd63553ed",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa06744edb04bbfba64b233e4755ea0fb98977f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573)
* 407dbd00b6169cf0df0667e76811d468356be63d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905)
* 2fe465933260f527c7776a89b2016e558457e634 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29913)
* 6ce750022ca8bfbf18e2df2eb496ad8fd63553ed UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on a change in pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #18381:
URL: https://github.com/apache/flink/pull/18381#discussion_r789664814
##########
File path: flink-annotations/src/main/java/org/apache/flink/FlinkVersion.java
##########
@@ -69,9 +71,14 @@ public boolean isNewerVersionThan(FlinkVersion otherVersion) {
}
/** Returns all versions equal to or higher than the selected version. */
- public Set<FlinkVersion> orHigher() {
+ public Set<FlinkVersion> orHigherMinusSnapshot() {
Review comment:
@zentol After a discussion with @twalthr we came up with another idea.
Keep only one enum the `FlinkVersion` without flags, and change the method to a `rangeOf` so that the tests can still define what they need. Additionally, if you agree with that, we will just change the steps `14` & `15` in the `Checklist to declare the process completed` section so that the release manager needs only to adjust the `CURRENT_VERSION` on `TypeSerializerUpgradeTestBase`.
Pushed the commit, so please check and let me know what do you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
}, {
"hash" : "407dbd00b6169cf0df0667e76811d468356be63d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905",
"triggerID" : "407dbd00b6169cf0df0667e76811d468356be63d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa06744edb04bbfba64b233e4755ea0fb98977f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573)
* 407dbd00b6169cf0df0667e76811d468356be63d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
}, {
"hash" : "407dbd00b6169cf0df0667e76811d468356be63d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905",
"triggerID" : "407dbd00b6169cf0df0667e76811d468356be63d",
"triggerType" : "PUSH"
}, {
"hash" : "2fe465933260f527c7776a89b2016e558457e634",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2fe465933260f527c7776a89b2016e558457e634",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa06744edb04bbfba64b233e4755ea0fb98977f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573)
* 407dbd00b6169cf0df0667e76811d468356be63d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905)
* 2fe465933260f527c7776a89b2016e558457e634 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
}, {
"hash" : "407dbd00b6169cf0df0667e76811d468356be63d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905",
"triggerID" : "407dbd00b6169cf0df0667e76811d468356be63d",
"triggerType" : "PUSH"
}, {
"hash" : "2fe465933260f527c7776a89b2016e558457e634",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29913",
"triggerID" : "2fe465933260f527c7776a89b2016e558457e634",
"triggerType" : "PUSH"
}, {
"hash" : "6ce750022ca8bfbf18e2df2eb496ad8fd63553ed",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29917",
"triggerID" : "6ce750022ca8bfbf18e2df2eb496ad8fd63553ed",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2fe465933260f527c7776a89b2016e558457e634 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29913)
* 6ce750022ca8bfbf18e2df2eb496ad8fd63553ed Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29917)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa06744edb04bbfba64b233e4755ea0fb98977f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on a change in pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #18381:
URL: https://github.com/apache/flink/pull/18381#discussion_r786503096
##########
File path: flink-annotations/src/main/java/org/apache/flink/FlinkVersion.java
##########
@@ -69,9 +71,14 @@ public boolean isNewerVersionThan(FlinkVersion otherVersion) {
}
/** Returns all versions equal to or higher than the selected version. */
- public Set<FlinkVersion> orHigher() {
+ public Set<FlinkVersion> orHigherMinusSnapshot() {
Review comment:
Suggestions are totally welcomed! :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
}, {
"hash" : "407dbd00b6169cf0df0667e76811d468356be63d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905",
"triggerID" : "407dbd00b6169cf0df0667e76811d468356be63d",
"triggerType" : "PUSH"
}, {
"hash" : "2fe465933260f527c7776a89b2016e558457e634",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2fe465933260f527c7776a89b2016e558457e634",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa06744edb04bbfba64b233e4755ea0fb98977f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573)
* 407dbd00b6169cf0df0667e76811d468356be63d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905)
* 2fe465933260f527c7776a89b2016e558457e634 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
}, {
"hash" : "407dbd00b6169cf0df0667e76811d468356be63d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905",
"triggerID" : "407dbd00b6169cf0df0667e76811d468356be63d",
"triggerType" : "PUSH"
}, {
"hash" : "2fe465933260f527c7776a89b2016e558457e634",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29913",
"triggerID" : "2fe465933260f527c7776a89b2016e558457e634",
"triggerType" : "PUSH"
}, {
"hash" : "6ce750022ca8bfbf18e2df2eb496ad8fd63553ed",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6ce750022ca8bfbf18e2df2eb496ad8fd63553ed",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa06744edb04bbfba64b233e4755ea0fb98977f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573)
* 407dbd00b6169cf0df0667e76811d468356be63d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905)
* 2fe465933260f527c7776a89b2016e558457e634 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29913)
* 6ce750022ca8bfbf18e2df2eb496ad8fd63553ed UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
}, {
"hash" : "407dbd00b6169cf0df0667e76811d468356be63d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "407dbd00b6169cf0df0667e76811d468356be63d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa06744edb04bbfba64b233e4755ea0fb98977f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573)
* 407dbd00b6169cf0df0667e76811d468356be63d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
}, {
"hash" : "407dbd00b6169cf0df0667e76811d468356be63d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905",
"triggerID" : "407dbd00b6169cf0df0667e76811d468356be63d",
"triggerType" : "PUSH"
}, {
"hash" : "2fe465933260f527c7776a89b2016e558457e634",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29913",
"triggerID" : "2fe465933260f527c7776a89b2016e558457e634",
"triggerType" : "PUSH"
}, {
"hash" : "6ce750022ca8bfbf18e2df2eb496ad8fd63553ed",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29917",
"triggerID" : "6ce750022ca8bfbf18e2df2eb496ad8fd63553ed",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa06744edb04bbfba64b233e4755ea0fb98977f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573)
* 407dbd00b6169cf0df0667e76811d468356be63d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905)
* 2fe465933260f527c7776a89b2016e558457e634 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29913)
* 6ce750022ca8bfbf18e2df2eb496ad8fd63553ed Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29917)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
}, {
"hash" : "407dbd00b6169cf0df0667e76811d468356be63d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905",
"triggerID" : "407dbd00b6169cf0df0667e76811d468356be63d",
"triggerType" : "PUSH"
}, {
"hash" : "2fe465933260f527c7776a89b2016e558457e634",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29913",
"triggerID" : "2fe465933260f527c7776a89b2016e558457e634",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa06744edb04bbfba64b233e4755ea0fb98977f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573)
* 407dbd00b6169cf0df0667e76811d468356be63d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905)
* 2fe465933260f527c7776a89b2016e558457e634 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29913)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa06744edb04bbfba64b233e4755ea0fb98977f8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on a change in pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #18381:
URL: https://github.com/apache/flink/pull/18381#discussion_r786840392
##########
File path: flink-annotations/src/main/java/org/apache/flink/FlinkVersion.java
##########
@@ -69,9 +71,14 @@ public boolean isNewerVersionThan(FlinkVersion otherVersion) {
}
/** Returns all versions equal to or higher than the selected version. */
- public Set<FlinkVersion> orHigher() {
+ public Set<FlinkVersion> orHigherMinusSnapshot() {
Review comment:
I thought about it too, to add a boolean to each enum (or default `true`) and the last one is always (`false`).
So I can rename the method to `orHigherReleased`? WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on a change in pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #18381:
URL: https://github.com/apache/flink/pull/18381#discussion_r787634018
##########
File path: flink-annotations/src/main/java/org/apache/flink/FlinkVersion.java
##########
@@ -69,9 +71,14 @@ public boolean isNewerVersionThan(FlinkVersion otherVersion) {
}
/** Returns all versions equal to or higher than the selected version. */
- public Set<FlinkVersion> orHigher() {
+ public Set<FlinkVersion> orHigherMinusSnapshot() {
Review comment:
@twalthr @zentol ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18381:
URL: https://github.com/apache/flink/pull/18381#discussion_r787702215
##########
File path: flink-annotations/src/main/java/org/apache/flink/FlinkVersion.java
##########
@@ -69,9 +71,14 @@ public boolean isNewerVersionThan(FlinkVersion otherVersion) {
}
/** Returns all versions equal to or higher than the selected version. */
- public Set<FlinkVersion> orHigher() {
+ public Set<FlinkVersion> orHigherMinusSnapshot() {
Review comment:
If anything the enum should have a boolean flag, but it seems somewhat overly complicated and isn't really intuitive.
For example, let's say we add this with the flag to 1.15. In the 1.15.0 release the `1_15` enum would still be marked as "not released", because if it were marked as released then the compatibility tests would complain. So we have release that considers itself as not released.
We also end up with _additional_ manual steps on _both_ the `master` and `release-1.15` branch, as they have to set this flag to true after 1.15.0 is released. But only after someone actually went through the trouble of creating the snapshots for the compatibility tests. And if we add additional table api compatibility tests, then this step just got worse.
I'm wondering if we shouldn't separate this distinction from the enum itself.
For example, there could be a flag (or separate ones per test) in the compatibility tests for whether they should also cover the latest version.
Or they could just ignore versions for which the files don't exist. Because as is we could never drop the 1.3 snapshots, because the enum still claims 1.3 exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
}, {
"hash" : "407dbd00b6169cf0df0667e76811d468356be63d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905",
"triggerID" : "407dbd00b6169cf0df0667e76811d468356be63d",
"triggerType" : "PUSH"
}, {
"hash" : "2fe465933260f527c7776a89b2016e558457e634",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29913",
"triggerID" : "2fe465933260f527c7776a89b2016e558457e634",
"triggerType" : "PUSH"
}, {
"hash" : "6ce750022ca8bfbf18e2df2eb496ad8fd63553ed",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29917",
"triggerID" : "6ce750022ca8bfbf18e2df2eb496ad8fd63553ed",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6ce750022ca8bfbf18e2df2eb496ad8fd63553ed Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29917)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
}, {
"hash" : "407dbd00b6169cf0df0667e76811d468356be63d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905",
"triggerID" : "407dbd00b6169cf0df0667e76811d468356be63d",
"triggerType" : "PUSH"
}, {
"hash" : "2fe465933260f527c7776a89b2016e558457e634",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29913",
"triggerID" : "2fe465933260f527c7776a89b2016e558457e634",
"triggerType" : "PUSH"
}, {
"hash" : "6ce750022ca8bfbf18e2df2eb496ad8fd63553ed",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6ce750022ca8bfbf18e2df2eb496ad8fd63553ed",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa06744edb04bbfba64b233e4755ea0fb98977f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573)
* 407dbd00b6169cf0df0667e76811d468356be63d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905)
* 2fe465933260f527c7776a89b2016e558457e634 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29913)
* 6ce750022ca8bfbf18e2df2eb496ad8fd63553ed UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
}, {
"hash" : "407dbd00b6169cf0df0667e76811d468356be63d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905",
"triggerID" : "407dbd00b6169cf0df0667e76811d468356be63d",
"triggerType" : "PUSH"
}, {
"hash" : "2fe465933260f527c7776a89b2016e558457e634",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2fe465933260f527c7776a89b2016e558457e634",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa06744edb04bbfba64b233e4755ea0fb98977f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573)
* 407dbd00b6169cf0df0667e76811d468356be63d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905)
* 2fe465933260f527c7776a89b2016e558457e634 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
}, {
"hash" : "407dbd00b6169cf0df0667e76811d468356be63d",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905",
"triggerID" : "407dbd00b6169cf0df0667e76811d468356be63d",
"triggerType" : "PUSH"
}, {
"hash" : "2fe465933260f527c7776a89b2016e558457e634",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29913",
"triggerID" : "2fe465933260f527c7776a89b2016e558457e634",
"triggerType" : "PUSH"
}, {
"hash" : "6ce750022ca8bfbf18e2df2eb496ad8fd63553ed",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29917",
"triggerID" : "6ce750022ca8bfbf18e2df2eb496ad8fd63553ed",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 407dbd00b6169cf0df0667e76811d468356be63d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905)
* 2fe465933260f527c7776a89b2016e558457e634 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29913)
* 6ce750022ca8bfbf18e2df2eb496ad8fd63553ed Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29917)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
matriv commented on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1020273713
FYI, I've updated the release guide accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014517164
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit fa06744edb04bbfba64b233e4755ea0fb98977f8 (Mon Jan 17 13:11:00 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa06744edb04bbfba64b233e4755ea0fb98977f8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
}, {
"hash" : "407dbd00b6169cf0df0667e76811d468356be63d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905",
"triggerID" : "407dbd00b6169cf0df0667e76811d468356be63d",
"triggerType" : "PUSH"
}, {
"hash" : "2fe465933260f527c7776a89b2016e558457e634",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2fe465933260f527c7776a89b2016e558457e634",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa06744edb04bbfba64b233e4755ea0fb98977f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573)
* 407dbd00b6169cf0df0667e76811d468356be63d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905)
* 2fe465933260f527c7776a89b2016e558457e634 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
}, {
"hash" : "407dbd00b6169cf0df0667e76811d468356be63d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905",
"triggerID" : "407dbd00b6169cf0df0667e76811d468356be63d",
"triggerType" : "PUSH"
}, {
"hash" : "2fe465933260f527c7776a89b2016e558457e634",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29913",
"triggerID" : "2fe465933260f527c7776a89b2016e558457e634",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa06744edb04bbfba64b233e4755ea0fb98977f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573)
* 407dbd00b6169cf0df0667e76811d468356be63d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905)
* 2fe465933260f527c7776a89b2016e558457e634 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29913)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
}, {
"hash" : "407dbd00b6169cf0df0667e76811d468356be63d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905",
"triggerID" : "407dbd00b6169cf0df0667e76811d468356be63d",
"triggerType" : "PUSH"
}, {
"hash" : "2fe465933260f527c7776a89b2016e558457e634",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29913",
"triggerID" : "2fe465933260f527c7776a89b2016e558457e634",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa06744edb04bbfba64b233e4755ea0fb98977f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573)
* 407dbd00b6169cf0df0667e76811d468356be63d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905)
* 2fe465933260f527c7776a89b2016e558457e634 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29913)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1014523784
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573",
"triggerID" : "fa06744edb04bbfba64b233e4755ea0fb98977f8",
"triggerType" : "PUSH"
}, {
"hash" : "407dbd00b6169cf0df0667e76811d468356be63d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905",
"triggerID" : "407dbd00b6169cf0df0667e76811d468356be63d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fa06744edb04bbfba64b233e4755ea0fb98977f8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29573)
* 407dbd00b6169cf0df0667e76811d468356be63d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29905)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Airblader commented on a change in pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
Airblader commented on a change in pull request #18381:
URL: https://github.com/apache/flink/pull/18381#discussion_r786763971
##########
File path: flink-annotations/src/main/java/org/apache/flink/FlinkVersion.java
##########
@@ -69,9 +71,14 @@ public boolean isNewerVersionThan(FlinkVersion otherVersion) {
}
/** Returns all versions equal to or higher than the selected version. */
- public Set<FlinkVersion> orHigher() {
+ public Set<FlinkVersion> orHigherMinusSnapshot() {
Review comment:
`orHigherExcludingLatest`?
I feel like "Snapshot" is not really correct here; I would expect e.g. `release-1.15` to contain 1.15 as the highest one as well (and not 1.16). But the question is whether 1.15 should be excluded on `release-1.15` or not (no idea, I don't know the intention).
Flagging the releases (`boolean released`). would be another option.
##########
File path: flink-annotations/src/main/java/org/apache/flink/FlinkVersion.java
##########
@@ -69,9 +71,14 @@ public boolean isNewerVersionThan(FlinkVersion otherVersion) {
}
/** Returns all versions equal to or higher than the selected version. */
- public Set<FlinkVersion> orHigher() {
+ public Set<FlinkVersion> orHigherMinusSnapshot() {
Review comment:
`orHigherExcludingLatest`?
I feel like "Snapshot" is not really correct here; I would expect e.g. `release-1.15` to contain 1.15 as the highest one as well (and not 1.16). But the question is whether 1.15 should be excluded on `release-1.15` or not (no idea, I don't know the intention).
Flagging the releases (`boolean released`) would be another option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
matriv commented on pull request #18381:
URL: https://github.com/apache/flink/pull/18381#issuecomment-1018525539
> I like this approach.
Thx! Let's wait for the build now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18381:
URL: https://github.com/apache/flink/pull/18381#discussion_r787702215
##########
File path: flink-annotations/src/main/java/org/apache/flink/FlinkVersion.java
##########
@@ -69,9 +71,14 @@ public boolean isNewerVersionThan(FlinkVersion otherVersion) {
}
/** Returns all versions equal to or higher than the selected version. */
- public Set<FlinkVersion> orHigher() {
+ public Set<FlinkVersion> orHigherMinusSnapshot() {
Review comment:
If anything the enum should have a boolean flag, but it seems somewhat overly complicated and isn't really intuitive.
For example, let's say we add this with the flag to 1.15. In the 1.15.0 release the `1_15` enum would still be marked as "not released", because if it were marked as released then the compatibility tests would complain. So we have release that considers itself as not released.
We also end up with _additional_ manual steps on _both_ the `master` and `release-1.15` branch, as they have to set this flag to true after 1.15.0 is released. But only after someone actually went through the trouble of creating the snapshots for the compatibility tests. And if we add additional table api compatibility tests, then this step just got worse.
I'm wondering if we shouldn't separate this distinction from the enum itself.
For example, there could be a flag (or separate ones per test) in the compatibility tests for whether they should also cover the latest version.
Or they could just ignore versions for which the files don't exist. As is we could never drop the 1.3 snapshots, because the enum still claims 1.3 exists. Although this adds a risk that the tests are completely broken and we don't notice it.
We could just introduce a separate enum/set for which Flink versions are relevant for compatibility tests. I think I'd prefer this option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #18381:
URL: https://github.com/apache/flink/pull/18381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18381: [hotfix][flink-annotations] Add v1.15 as the next Flink version to master
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18381:
URL: https://github.com/apache/flink/pull/18381#discussion_r787702215
##########
File path: flink-annotations/src/main/java/org/apache/flink/FlinkVersion.java
##########
@@ -69,9 +71,14 @@ public boolean isNewerVersionThan(FlinkVersion otherVersion) {
}
/** Returns all versions equal to or higher than the selected version. */
- public Set<FlinkVersion> orHigher() {
+ public Set<FlinkVersion> orHigherMinusSnapshot() {
Review comment:
If anything the enum should have a boolean flag, but it seems somewhat overly complicated and isn't really intuitive.
For example, let's say we add this with the flag to 1.15. In the 1.15.0 release the `1_15` enum would still be marked as "not released", because if it were marked as released then the compatibility tests would complain. So we have release that considers itself as not released.
We also end up with _additional_ manual steps on _both_ the `master` and `release-1.15` branch, as they have to set this flag to true after 1.15.0 is released. But only after someone actually went through the trouble of creating the snapshots for the compatibility tests. And if we add additional table api compatibility tests, then this step just got worse.
I'm wondering if we shouldn't separate this distinction from the enum itself.
For example, there could be a flag (or separate ones per test) in the compatibility tests for whether they should also cover the latest version.
Or they could just ignore versions for which the files don't exist. Because as is we could never drop the 1.3 snapshots, because the enum still claims 1.3 exists. Although this adds a risk that the tests are completely broken and we don't notice it.
Or, we could just introduce a separate enum/set for which Flink versions are relevant for compatibility tests. I think I'd prefer this option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org