You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/21 20:44:03 UTC

[GitHub] [airflow] houqp commented on a change in pull request #15172: Execute `on_failure_callback` when SIGTERM is received

houqp commented on a change in pull request #15172:
URL: https://github.com/apache/airflow/pull/15172#discussion_r617863627



##########
File path: tests/jobs/test_local_task_job.py
##########
@@ -495,6 +496,69 @@ def task_function(ti):
         assert task_terminated_externally.value == 1
         assert not process.is_alive()
 
+    def test_process_kill_call_on_failure_callback(self):
+        """
+        Test that ensures that when a task is killed with sigterm

Review comment:
       nitpick
   
   ```suggestion
           Test that ensures that when the local_task_job is killed with sigterm
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org