[GitHub] [incubator-inlong] gong edited a comment on pull request #2792: [INlONG-2791][Manager] Optimize manager client APIs

[GitBox <gi...@apache.org>]

gong edited a comment on pull request #2792:
URL: https://github.com/apache/incubator-inlong/pull/2792#issuecomment-1054989353


   only modify `SinkPageRequest` and `SourcePageRequest` will cause some problem.
   
   StreamSinkServiceImpl
   
   ```java
   public PageInfo<? extends SinkListResponse> listByCondition(SinkPageRequest request) {
           if (LOGGER.isDebugEnabled()) {
               LOGGER.debug("begin to list sink page by " + request);
           }
           Preconditions.checkNotNull(request.getInlongGroupId(), Constant.GROUP_ID_IS_EMPTY);
           String sinkType = request.getSinkType();
           Preconditions.checkNotNull(sinkType, Constant.SINK_TYPE_IS_EMPTY);
   ```
   
   StreamSourceServiceImpl
   
   ```java
   public PageInfo<? extends SourceListResponse> listByCondition(SourcePageRequest request) {
           if (LOGGER.isDebugEnabled()) {
               LOGGER.debug("begin to list source page by " + request);
           }
           Preconditions.checkNotNull(request.getInlongGroupId(), Constant.GROUP_ID_IS_EMPTY);
           String sourceType = request.getSourceType();
           Preconditions.checkNotNull(sourceType, Constant.SOURCE_TYPE_IS_EMPTY);
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org