You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/06 03:42:36 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #38120: [SPARK-40674][CONNECT][PYTHON][TESTS] Use uniitest's asserts instead of built-in assert
HyukjinKwon opened a new pull request, #38120:
URL: https://github.com/apache/spark/pull/38120
### What changes were proposed in this pull request?
This PR proposes to use unittest' assert API instead of Python's built-in assert in Spark Connect tests.
### Why are the changes needed?
For better error message when a test fails, and consisten codebase.
### Does this PR introduce _any_ user-facing change?
No, test-only.
### How was this patch tested?
CI in this PR should verify it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38120: [SPARK-40674][CONNECT][PYTHON][TESTS] Use uniitest's asserts instead of built-in assert
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38120:
URL: https://github.com/apache/spark/pull/38120#issuecomment-1269414699
connect tests passed.
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38120: [SPARK-40674][CONNECT][PYTHON][TESTS] Use uniitest's asserts instead of built-in assert
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38120:
URL: https://github.com/apache/spark/pull/38120#issuecomment-1269275511
cc @amaliujia @itholic @ueshin @xinrong-meng @zhengruifeng if you find some time to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38120: [SPARK-40674][CONNECT][PYTHON][TESTS] Use uniitest's asserts instead of built-in assert
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38120:
URL: https://github.com/apache/spark/pull/38120#issuecomment-1269375101
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #38120: [SPARK-40674][CONNECT][PYTHON][TESTS] Use uniitest's asserts instead of built-in assert
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38120: [SPARK-40674][CONNECT][PYTHON][TESTS] Use uniitest's asserts instead of built-in assert
URL: https://github.com/apache/spark/pull/38120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org