You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "parisni (via GitHub)" <gi...@apache.org> on 2023/06/13 10:28:56 UTC
[GitHub] [hudi] parisni opened a new pull request, #8740: [HUDI-6231] Handle glue comments
parisni opened a new pull request, #8740:
URL: https://github.com/apache/hudi/pull/8740
### Change Logs
This adds the glue metastore comments feature - which was not implemented yet. Tools such athena or presto are then able to grab the comment when describe operation is done. However spark hudi won't grab them from the metastore, instead it get them from the avro schema on s3.
I don't see a way to add tests to this, since it would need a local aws stack to mimic glue
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8740: [HUDI-6231] Handle glue comments
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8740:
URL: https://github.com/apache/hudi/pull/8740#issuecomment-1587604420
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6da10d497c4c7c9419ae51599929d2f9d2198a1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17156",
"triggerID" : "f6da10d497c4c7c9419ae51599929d2f9d2198a1",
"triggerType" : "PUSH"
}, {
"hash" : "cb22b6dd9f799e2647a89f58767cc1f381f047e4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17773",
"triggerID" : "cb22b6dd9f799e2647a89f58767cc1f381f047e4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6da10d497c4c7c9419ae51599929d2f9d2198a1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17156)
* cb22b6dd9f799e2647a89f58767cc1f381f047e4 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17773)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8740: [HUDI-6231] Handle glue comments
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8740:
URL: https://github.com/apache/hudi/pull/8740#issuecomment-1551444552
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6da10d497c4c7c9419ae51599929d2f9d2198a1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f6da10d497c4c7c9419ae51599929d2f9d2198a1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6da10d497c4c7c9419ae51599929d2f9d2198a1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #8740: [HUDI-6231] Handle glue comments
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 merged PR #8740:
URL: https://github.com/apache/hudi/pull/8740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] parisni commented on pull request #8740: [HUDI-6231] Handle glue comments
Posted by "parisni (via GitHub)" <gi...@apache.org>.
parisni commented on PR #8740:
URL: https://github.com/apache/hudi/pull/8740#issuecomment-1585529193
Yes we did
On June 9, 2023 11:49:44 PM UTC, Y Ethan Guo ***@***.***> wrote:
>Hi @parisni, I assume you have manually tested this with Glue catalog, correct?
>
>--
>Reply to this email directly or view it on GitHub:
>https://github.com/apache/hudi/pull/8740#issuecomment-1585288799
>You are receiving this because you were mentioned.
>
>Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] parisni commented on pull request #8740: [HUDI-6231] Handle glue comments
Posted by "parisni (via GitHub)" <gi...@apache.org>.
parisni commented on PR #8740:
URL: https://github.com/apache/hudi/pull/8740#issuecomment-1572624810
> @parisni Hi, do we have plan to push-forward this feature?
Yes I do. I am currently in vacations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8740: [HUDI-6231] Handle glue comments
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8740:
URL: https://github.com/apache/hudi/pull/8740#issuecomment-1551459939
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6da10d497c4c7c9419ae51599929d2f9d2198a1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17156",
"triggerID" : "f6da10d497c4c7c9419ae51599929d2f9d2198a1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6da10d497c4c7c9419ae51599929d2f9d2198a1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17156)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] parisni commented on a diff in pull request #8740: [HUDI-6231] Handle glue comments
Posted by "parisni (via GitHub)" <gi...@apache.org>.
parisni commented on code in PR #8740:
URL: https://github.com/apache/hudi/pull/8740#discussion_r1217980277
##########
hudi-aws/src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java:
##########
@@ -238,6 +235,66 @@ public void updateTableProperties(String tableName, Map<String, String> tablePro
}
}
+ private void setComments(List<Column> columns, Map<String, Option<String>> commentsMap) {
+ columns.forEach(column -> {
+ String comment = commentsMap.getOrDefault(column.getName(), Option.empty()).orElse(null);
+ column.setComment(comment);
+ });
+ }
+
+ private String getTableDoc() {
+ try {
+ return new TableSchemaResolver(metaClient).getTableAvroSchema(true).getDoc();
+ } catch (Exception e) {
Review Comment:
AFAIK the avro schema is already reused by running method `getTableAvroSchema` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8740: [HUDI-6231] Handle glue comments
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8740:
URL: https://github.com/apache/hudi/pull/8740#issuecomment-1589336245
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6da10d497c4c7c9419ae51599929d2f9d2198a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17156",
"triggerID" : "f6da10d497c4c7c9419ae51599929d2f9d2198a1",
"triggerType" : "PUSH"
}, {
"hash" : "cb22b6dd9f799e2647a89f58767cc1f381f047e4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17773",
"triggerID" : "cb22b6dd9f799e2647a89f58767cc1f381f047e4",
"triggerType" : "PUSH"
}, {
"hash" : "cb22b6dd9f799e2647a89f58767cc1f381f047e4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17798",
"triggerID" : "1589012582",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* cb22b6dd9f799e2647a89f58767cc1f381f047e4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17773) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17798)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] parisni commented on pull request #8740: [HUDI-6231] Handle glue comments
Posted by "parisni (via GitHub)" <gi...@apache.org>.
parisni commented on PR #8740:
URL: https://github.com/apache/hudi/pull/8740#issuecomment-1576669846
@danny0405 it is aws and not gcp (about the tags changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 closed pull request #8740: [HUDI-6231] Handle glue comments
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 closed pull request #8740: [HUDI-6231] Handle glue comments
URL: https://github.com/apache/hudi/pull/8740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8740: [HUDI-6231] Handle glue comments
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8740:
URL: https://github.com/apache/hudi/pull/8740#issuecomment-1552455756
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6da10d497c4c7c9419ae51599929d2f9d2198a1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17156",
"triggerID" : "f6da10d497c4c7c9419ae51599929d2f9d2198a1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6da10d497c4c7c9419ae51599929d2f9d2198a1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17156)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8740: [HUDI-6231] Handle glue comments
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8740:
URL: https://github.com/apache/hudi/pull/8740#issuecomment-1571277471
@parisni Hi, do we have plan to push-forward this feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on pull request #8740: [HUDI-6231] Handle glue comments
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #8740:
URL: https://github.com/apache/hudi/pull/8740#issuecomment-1585288799
Hi @parisni, I assume you have manually tested this with Glue catalog, correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8740: [HUDI-6231] Handle glue comments
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8740:
URL: https://github.com/apache/hudi/pull/8740#issuecomment-1587954388
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6da10d497c4c7c9419ae51599929d2f9d2198a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17156",
"triggerID" : "f6da10d497c4c7c9419ae51599929d2f9d2198a1",
"triggerType" : "PUSH"
}, {
"hash" : "cb22b6dd9f799e2647a89f58767cc1f381f047e4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17773",
"triggerID" : "cb22b6dd9f799e2647a89f58767cc1f381f047e4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cb22b6dd9f799e2647a89f58767cc1f381f047e4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17773)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #8740: [HUDI-6231] Handle glue comments
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #8740:
URL: https://github.com/apache/hudi/pull/8740#discussion_r1201754622
##########
hudi-aws/src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java:
##########
@@ -238,6 +235,66 @@ public void updateTableProperties(String tableName, Map<String, String> tablePro
}
}
+ private void setComments(List<Column> columns, Map<String, Option<String>> commentsMap) {
+ columns.forEach(column -> {
+ String comment = commentsMap.getOrDefault(column.getName(), Option.empty()).orElse(null);
+ column.setComment(comment);
+ });
+ }
+
+ private String getTableDoc() {
+ try {
+ return new TableSchemaResolver(metaClient).getTableAvroSchema(true).getDoc();
+ } catch (Exception e) {
Review Comment:
Can the table avro schema be reused?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8740: [HUDI-6231] Handle glue comments
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8740:
URL: https://github.com/apache/hudi/pull/8740#issuecomment-1585982482
@parisni
Can you fix the checkstyle issue:
```java
Error: src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java:[26,8] (imports) UnusedImports: Unused import - org.apache.hudi.hive.HoodieHiveSyncException.
Error: src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java:[63] (imports) AvoidStarImport: Using the '.*' form of import should be avoided - java.util.*.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8740: [HUDI-6231] Handle glue comments
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8740:
URL: https://github.com/apache/hudi/pull/8740#issuecomment-1589034992
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6da10d497c4c7c9419ae51599929d2f9d2198a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17156",
"triggerID" : "f6da10d497c4c7c9419ae51599929d2f9d2198a1",
"triggerType" : "PUSH"
}, {
"hash" : "cb22b6dd9f799e2647a89f58767cc1f381f047e4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17773",
"triggerID" : "cb22b6dd9f799e2647a89f58767cc1f381f047e4",
"triggerType" : "PUSH"
}, {
"hash" : "cb22b6dd9f799e2647a89f58767cc1f381f047e4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17798",
"triggerID" : "1589012582",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* cb22b6dd9f799e2647a89f58767cc1f381f047e4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17773) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17798)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #8740: [HUDI-6231] Handle glue comments
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8740:
URL: https://github.com/apache/hudi/pull/8740#issuecomment-1587590544
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f6da10d497c4c7c9419ae51599929d2f9d2198a1",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17156",
"triggerID" : "f6da10d497c4c7c9419ae51599929d2f9d2198a1",
"triggerType" : "PUSH"
}, {
"hash" : "cb22b6dd9f799e2647a89f58767cc1f381f047e4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cb22b6dd9f799e2647a89f58767cc1f381f047e4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f6da10d497c4c7c9419ae51599929d2f9d2198a1 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=17156)
* cb22b6dd9f799e2647a89f58767cc1f381f047e4 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] parisni commented on pull request #8740: [HUDI-6231] Handle glue comments
Posted by "parisni (via GitHub)" <gi...@apache.org>.
parisni commented on PR #8740:
URL: https://github.com/apache/hudi/pull/8740#issuecomment-1587601208
@danny0405 rebased master, fixed imports, and also tested locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #8740: [HUDI-6231] Handle glue comments
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #8740:
URL: https://github.com/apache/hudi/pull/8740#issuecomment-1589012582
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org