You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/09/20 12:27:00 UTC
[jira] [Commented] (AVRO-2078) Avro does not enforce schema
resolution rules for Decimal type
[ https://issues.apache.org/jira/browse/AVRO-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173094#comment-16173094 ]
ASF GitHub Bot commented on AVRO-2078:
--------------------------------------
GitHub user nandorKollar opened a pull request:
https://github.com/apache/avro/pull/247
AVRO-2078: Avro does not enforce schema resolution rules for Decimal …
…type
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nandorKollar/avro AVRO-2078
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/avro/pull/247.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #247
----
commit 3753c8ac285b3cfc5aeec399e526dc84f98b54aa
Author: Nandor Kollar <nk...@cloudera.com>
Date: 2017-09-20T12:23:17Z
AVRO-2078: Avro does not enforce schema resolution rules for Decimal type
----
> Avro does not enforce schema resolution rules for Decimal type
> --------------------------------------------------------------
>
> Key: AVRO-2078
> URL: https://issues.apache.org/jira/browse/AVRO-2078
> Project: Avro
> Issue Type: Bug
> Reporter: Anthony Hsu
> Fix For: 1.8.2
>
> Attachments: dec.avro
>
>
> According to http://avro.apache.org/docs/1.8.2/spec.html#Decimal
> bq. For the purposes of schema resolution, two schemas that are {{decimal}} logical types _match_ if their scales and precisions match.
> This is not enforced.
> I wrote a file with (precision 5, scale 2) and tried to read it with a reader schema with (precision 3, scale 1). I expected an AvroTypeException to be thrown, but none was thrown.
> Test data file attached. The code to read it is:
> {noformat:title=ReadDecimal.java}
> import java.io.File;
> import org.apache.avro.Schema;
> import org.apache.avro.file.DataFileReader;
> import org.apache.avro.generic.GenericDatumReader;
> import org.apache.avro.generic.GenericRecord;
> import org.apache.avro.io.DatumReader;
> public class ReadDecimal {
> public static void main(String[] args) throws Exception {
> Schema schema = new Schema.Parser().parse("{\n" + " \"type\" : \"record\",\n" + " \"name\" : \"some_schema\",\n"
> + " \"namespace\" : \"com.howdy\",\n" + " \"fields\" : [ {\n" + " \"name\" : \"name\",\n"
> + " \"type\" : \"string\"\n" + " }, {\n" + " \"name\" : \"value\",\n" + " \"type\" : {\n"
> + " \"type\" : \"bytes\",\n" + " \"logicalType\" : \"decimal\",\n" + " \"precision\" : 3,\n"
> + " \"scale\" : 1\n" + " }\n" + " } ]\n" + "}");
> DatumReader<GenericRecord> datumReader = new GenericDatumReader<>(schema);
> // dec.avro has precision 5, scale 2
> DataFileReader<GenericRecord> dataFileReader = new DataFileReader<>(
> new File("/tmp/dec.avro"), datumReader);
> GenericRecord foo = null;
> while (dataFileReader.hasNext()) {
> foo = dataFileReader.next(foo); // AvroTypeException expected due to change in scale/precision but none occurs
> }
> }
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)