You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/16 04:48:01 UTC

[GitHub] [hudi] yihua commented on a change in pull request #4003: [HUDI-2734] Setting default metadata enable per engine

yihua commented on a change in pull request #4003:
URL: https://github.com/apache/hudi/pull/4003#discussion_r749896360



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/config/HoodieMetadataConfig.java
##########
@@ -18,6 +18,9 @@
 
 package org.apache.hudi.common.config;
 
+import org.apache.hudi.common.engine.EngineType;
+import org.apache.hudi.exception.HoodieNotSupportedException;
+
 import javax.annotation.concurrent.Immutable;
 
 import java.io.File;

Review comment:
       Should `ENABLE` be set with `.noDefaultValue()`?  If not, engine-specific values are overwritten?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org