You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bharat kumar <bh...@citrix.com> on 2013/06/03 13:10:33 UTC

Re: Review Request: CLOUDSTACK-2620 [Multiple_IP_Ranges] Guest vm's nameserver is not set to VRs guest IP address in case of multiple subnets

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11436/
-----------------------------------------------------------

(Updated June 3, 2013, 11:10 a.m.)


Review request for cloudstack, Abhinandan Prateek and Koushik Das.


Changes
-------

update the diff with review comments.


Description
-------

[Multiple_IP_Ranges] Guest vm's nameserver is not set to VRs guest IP address in case of multiple subnets
https://issues.apache.org/jira/browse/CLOUDSTACK-2620


This addresses bug Cloudstack-2620.


Diffs (updated)
-----

  api/src/com/cloud/agent/api/to/DnsmasqTO.java f99878c 
  core/src/com/cloud/network/DnsMasqConfigurator.java ee8e5fc 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java c71d037 

Diff: https://reviews.apache.org/r/11436/diff/


Testing
-------

tested on master.


Thanks,

bharat kumar


Re: Review Request: CLOUDSTACK-2620 [Multiple_IP_Ranges] Guest vm's nameserver is not set to VRs guest IP address in case of multiple subnets

Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11436/#review21314
-----------------------------------------------------------

Ship it!


Ship It!

- Koushik Das


On June 3, 2013, 1:08 p.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11436/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 1:08 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
> 
> 
> Description
> -------
> 
> [Multiple_IP_Ranges] Guest vm's nameserver is not set to VRs guest IP address in case of multiple subnets
> https://issues.apache.org/jira/browse/CLOUDSTACK-2620
> 
> 
> This addresses bug Cloudstack-2620.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/agent/api/to/DnsmasqTO.java f99878c 
>   core/src/com/cloud/network/DnsMasqConfigurator.java ee8e5fc 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java c71d037 
> 
> Diff: https://reviews.apache.org/r/11436/diff/
> 
> 
> Testing
> -------
> 
> tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>


Re: Review Request: CLOUDSTACK-2620 [Multiple_IP_Ranges] Guest vm's nameserver is not set to VRs guest IP address in case of multiple subnets

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11436/#review21317
-----------------------------------------------------------


Commit 0a69b828993088487876ce859e6c00e96e4b545c in branch refs/heads/master from Abhinandan Prateek <ap...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0a69b82 ]

CLOUDSTACK-2620 [Multiple_IP_Ranges] Guest vm's nameserver is not set to VRs guest IP address in case of multiple subnets

Signed-off-by: Abhinandan Prateek <ap...@apache.org>


- ASF Subversion and Git Services


On June 3, 2013, 1:08 p.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11436/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 1:08 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
> 
> 
> Description
> -------
> 
> [Multiple_IP_Ranges] Guest vm's nameserver is not set to VRs guest IP address in case of multiple subnets
> https://issues.apache.org/jira/browse/CLOUDSTACK-2620
> 
> 
> This addresses bug Cloudstack-2620.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/agent/api/to/DnsmasqTO.java f99878c 
>   core/src/com/cloud/network/DnsMasqConfigurator.java ee8e5fc 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java c71d037 
> 
> Diff: https://reviews.apache.org/r/11436/diff/
> 
> 
> Testing
> -------
> 
> tested on master.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>


Re: Review Request: CLOUDSTACK-2620 [Multiple_IP_Ranges] Guest vm's nameserver is not set to VRs guest IP address in case of multiple subnets

Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11436/
-----------------------------------------------------------

(Updated June 3, 2013, 1:08 p.m.)


Review request for cloudstack, Abhinandan Prateek and Koushik Das.


Description
-------

[Multiple_IP_Ranges] Guest vm's nameserver is not set to VRs guest IP address in case of multiple subnets
https://issues.apache.org/jira/browse/CLOUDSTACK-2620


This addresses bug Cloudstack-2620.


Diffs (updated)
-----

  api/src/com/cloud/agent/api/to/DnsmasqTO.java f99878c 
  core/src/com/cloud/network/DnsMasqConfigurator.java ee8e5fc 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java c71d037 

Diff: https://reviews.apache.org/r/11436/diff/


Testing
-------

tested on master.


Thanks,

bharat kumar


Re: Review Request: CLOUDSTACK-2620 [Multiple_IP_Ranges] Guest vm's nameserver is not set to VRs guest IP address in case of multiple subnets

Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11436/
-----------------------------------------------------------

(Updated June 3, 2013, 12:07 p.m.)


Review request for cloudstack, Abhinandan Prateek and Koushik Das.


Description
-------

[Multiple_IP_Ranges] Guest vm's nameserver is not set to VRs guest IP address in case of multiple subnets
https://issues.apache.org/jira/browse/CLOUDSTACK-2620


This addresses bug Cloudstack-2620.


Diffs (updated)
-----

  api/src/com/cloud/agent/api/to/DnsmasqTO.java f99878c 
  core/src/com/cloud/network/DnsMasqConfigurator.java ee8e5fc 
  server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java c71d037 

Diff: https://reviews.apache.org/r/11436/diff/


Testing
-------

tested on master.


Thanks,

bharat kumar