[GitHub] geode pull request #720: GEODE-3462: FunctionStats Exposed over JMX

[kirklund <gi...@git.apache.org>]

Github user kirklund commented on a diff in the pull request:

    https://github.com/apache/geode/pull/720#discussion_r134003423
  
    --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java ---
    @@ -3138,7 +3138,7 @@ public Pool determineDefaultPool(PoolFactory poolFactory) {
         invokeRegionAfter(region);
     
         // Added for M&M . Putting the callback here to avoid creating RegionMBean in case of Exception
    -    if (!region.isInternalRegion()) {
    +    if (region.isRegionRegistrationRequireOnJmx()) {
    --- End diff --
    
    As a community we are trying to refactor code and separate concerns. This change is going in the wrong direction -- you're combining JMX concerns into Cache and Region which is beyond the scope of these classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---