You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openmeetings.apache.org by GitBox <gi...@apache.org> on 2022/07/30 22:51:41 UTC

[GitHub] [openmeetings] sebawagner opened a new pull request, #182: OPENMEETINGS-2748 Add and update build instructions.

sebawagner opened a new pull request, #182:
URL: https://github.com/apache/openmeetings/pull/182

   Update build instructions. I think the Wicket.mode was missing, it fails without it.
   
   Otherwise I think just publishing the changes on the website may have been missing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openmeetings] solomax merged pull request #182: OPENMEETINGS-2748 Add and update build instructions.

Posted by GitBox <gi...@apache.org>.
solomax merged PR #182:
URL: https://github.com/apache/openmeetings/pull/182


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openmeetings] sebawagner commented on a diff in pull request #182: OPENMEETINGS-2748 Add and update build instructions.

Posted by GitBox <gi...@apache.org>.
sebawagner commented on code in PR #182:
URL: https://github.com/apache/openmeetings/pull/182#discussion_r933901266


##########
openmeetings-server/src/site/xdoc/BuildInstructions.xml:
##########
@@ -63,12 +63,28 @@
 		<section name="Tips and Gotchas">
 			<p>Eclipse ANSI colors plugin for colors in console</p>
 			<source><![CDATA[
-MAVEN_OPTS='-Xdebug -Xrunjdwp:transport=dt_socket,address=8787,server=y,suspend=n' mvn clean -P allModules,quick,mysql jetty:run-exploded -Dwicket.ioc.useByteBuddy=true
+MAVEN_OPTS='-Xdebug -Xrunjdwp:transport=dt_socket,address=8787,server=y,suspend=n' mvn clean -P allModules,quick,mysql jetty:run-exploded -Dwicket.configuration=DEVELOPMENT -Dwicket.ioc.useByteBuddy=true
 
 #Quick rebuild and run
-cd ..; mvn clean install -PallModules,quick,mysql -pl openmeetings-util,openmeetings-core; cd openmeetings-web; MAVEN_OPTS='-Xdebug -Xrunjdwp:transport=dt_socket,address=8787,server=y,suspend=n' mvn clean -P allModules,quick,mysql jetty:run-exploded -Dwicket.ioc.useByteBuddy=true
+cd ..; mvn clean install -PallModules,quick,mysql -pl openmeetings-util,openmeetings-core; cd openmeetings-web; MAVEN_OPTS='-Xdebug -Xrunjdwp:transport=dt_socket,address=8787,server=y,suspend=n' mvn clean -P allModules,quick,mysql jetty:run-exploded -Dwicket.configuration=DEVELOPMENT -Dwicket.ioc.useByteBuddy=true
 
 			]]></source>
+			<p>Run OpenMeetings with Embedded Jetty for Development purpose in JDK17</p>
+			<source>
+<![CDATA[
+# ANSI console colors and fix Hazelcast warnings for access

Review Comment:
   See also https://issues.apache.org/jira/browse/OPENMEETINGS-2749



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [openmeetings] sebawagner commented on pull request #182: OPENMEETINGS-2748 Add and update build instructions.

Posted by GitBox <gi...@apache.org>.
sebawagner commented on PR #182:
URL: https://github.com/apache/openmeetings/pull/182#issuecomment-1200309790

   Assuming this replicates the same fix into embedded jetty build instructions I assume this should be fine, once Jenkins has validated the Pull Request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@openmeetings.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org