You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/14 08:47:19 UTC
[GitHub] [maven-mvnd] gzm55 opened a new pull request, #712: Add 'mvnd.rawStreams' property
gzm55 opened a new pull request, #712:
URL: https://github.com/apache/maven-mvnd/pull/712
1. add `mvnd.rawStreams=<boolean>` property to control the stdout/stderr stream
2. `--raw-streams` cli option overrides `-Dmvnd.rawStreams=...`
3. move `--raw-streams` a mvnd specific option
closes #708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-mvnd] gzm55 commented on pull request #712: Add 'mvnd.rawStreams' property
Posted by GitBox <gi...@apache.org>.
gzm55 commented on PR #712:
URL: https://github.com/apache/maven-mvnd/pull/712#issuecomment-1279968457
> > > Is there any good reason to keep both an option and a property ? I think they should be merged together.
> >
> >
> > if merged, with type `OptionType.VOID`, the [`getCommandLineOption`](https://github.com/apache/maven-mvnd/blob/5e59c404535ba21b925a372340c7b11749aa4050/common/src/main/java/org/mvndaemon/mvnd/common/Environment.java#L425) will ignore the value following `-Dmvnd.rawStreams=....`. Another property `mvnd.serial` should have the same problem.
>
> I think that's a bug, they should be `OptionType.BOOLEAN`, shouldn't they ?
For non-parameter switch `-1`, `--serial` or `--raw-streams`, the type should be `VOID`, whereas all the property should not be `VOID`. To support the merging of a property and a void cli switch, we have to assign two types to one `Environment`. I think there should be better another pr to improve these cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-mvnd] gzm55 commented on pull request #712: Add 'mvnd.rawStreams' property
Posted by GitBox <gi...@apache.org>.
gzm55 commented on PR #712:
URL: https://github.com/apache/maven-mvnd/pull/712#issuecomment-1279959974
> Is there any good reason to keep both an option and a property ? I think they should be merged together.
if merged, with type `OptionType.VOID`, the [`getCommandLineOption`](https://github.com/apache/maven-mvnd/blob/5e59c404535ba21b925a372340c7b11749aa4050/common/src/main/java/org/mvndaemon/mvnd/common/Environment.java#L425) will ignore the value following `-Dmvnd.rawStreams=....`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-mvnd] gzm55 commented on pull request #712: Add 'mvnd.rawStreams' property
Posted by GitBox <gi...@apache.org>.
gzm55 commented on PR #712:
URL: https://github.com/apache/maven-mvnd/pull/712#issuecomment-1280155637
prefer #719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-mvnd] gzm55 closed pull request #712: Add 'mvnd.rawStreams' property
Posted by GitBox <gi...@apache.org>.
gzm55 closed pull request #712: Add 'mvnd.rawStreams' property
URL: https://github.com/apache/maven-mvnd/pull/712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-mvnd] gzm55 commented on pull request #712: Add 'mvnd.rawStreams' property
Posted by GitBox <gi...@apache.org>.
gzm55 commented on PR #712:
URL: https://github.com/apache/maven-mvnd/pull/712#issuecomment-1280000646
another method, remove `--raw-streams` option, then use `-Dmvnd.rawStreams` as a `void` cli option.
Pros: do not change structure of `Environment`; less incompatible options between `mvnd` and `maven`
Cons: break the cli interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on pull request #712: Add 'mvnd.rawStreams' property
Posted by GitBox <gi...@apache.org>.
gnodet commented on PR #712:
URL: https://github.com/apache/maven-mvnd/pull/712#issuecomment-1279962800
> > Is there any good reason to keep both an option and a property ? I think they should be merged together.
>
> if merged, with type `OptionType.VOID`, the [`getCommandLineOption`](https://github.com/apache/maven-mvnd/blob/5e59c404535ba21b925a372340c7b11749aa4050/common/src/main/java/org/mvndaemon/mvnd/common/Environment.java#L425) will ignore the value following `-Dmvnd.rawStreams=....`. Another property `mvnd.serial` should have the same problem.
I think that's a bug, they should be `OptionType.BOOLEAN`, shouldn't they ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on pull request #712: Add 'mvnd.rawStreams' property
Posted by GitBox <gi...@apache.org>.
gnodet commented on PR #712:
URL: https://github.com/apache/maven-mvnd/pull/712#issuecomment-1279971813
> > > > Is there any good reason to keep both an option and a property ? I think they should be merged together.
> > >
> > >
> > > if merged, with type `OptionType.VOID`, the [`getCommandLineOption`](https://github.com/apache/maven-mvnd/blob/5e59c404535ba21b925a372340c7b11749aa4050/common/src/main/java/org/mvndaemon/mvnd/common/Environment.java#L425) will ignore the value following `-Dmvnd.rawStreams=....`. Another property `mvnd.serial` should have the same problem.
> >
> >
> > I think that's a bug, they should be `OptionType.BOOLEAN`, shouldn't they ?
>
> For non-parameter switch `-1`, `--serial` or `--raw-streams`, the type should be `VOID`, whereas all the property should not be `VOID`. To support the merging of a property and a void cli switch, we have to assign two types to one `Environment`. I think there should be better another pr to improve these cases.
Agreed !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org