[GitHub] [jmeter] vlsi commented on a diff in pull request #5944: feat: Enable usage of ${...} expressions for checkbox controls

["vlsi (via GitHub)" <gi...@apache.org>]

vlsi commented on code in PR #5944:
URL: https://github.com/apache/jmeter/pull/5944#discussion_r1216257965


##########
src/core/src/main/java/org/apache/jmeter/testelement/AbstractTestElement.java:
##########
@@ -342,7 +343,7 @@ public int getPropertyAsInt(String key) {
 
     @Override
     public int getPropertyAsInt(String key, int defaultValue) {
-        JMeterProperty jmp = getRawProperty(key);
+        JMeterProperty jmp = getPropertyOrNull(key);
         return jmp == null || jmp instanceof NullProperty ? defaultValue : jmp.getIntValue();

Review Comment:
   Frankly speaking, `getPropertyOrNull` followed by `instanceof NullProperty` look strange, however, I do not change it in the current PR.
   However, it would probably make sense to revise it later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org