You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Ryan McKinley (JIRA)" <ji...@apache.org> on 2012/06/28 09:25:42 UTC
[jira] [Created] (LUCENE-4175) Include BBox Spatial Strategy
Ryan McKinley created LUCENE-4175:
-------------------------------------
Summary: Include BBox Spatial Strategy
Key: LUCENE-4175
URL: https://issues.apache.org/jira/browse/LUCENE-4175
Project: Lucene - Java
Issue Type: Improvement
Reporter: Ryan McKinley
Assignee: Ryan McKinley
This is an approach to indexing bounding boxes using 4 numeric fields (xmin,ymin,xmax,ymax) and a flag to say if it crosses the dateline.
This is a modification from the Apache 2.0 code from the ESRI Geoportal:
http://geoportal.svn.sourceforge.net/svnroot/geoportal/Geoportal/trunk/src/com/esri/gpt/catalog/lucene/SpatialClauseAdapter.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Comment Edited] (LUCENE-4175) Include BBox Spatial Strategy
Posted by "David Smiley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458050#comment-13458050 ]
David Smiley edited comment on LUCENE-4175 at 9/19/12 5:52 AM:
---------------------------------------------------------------
The BBoxStrategy is tested insofar as search filtering and returning the standard center-point distance as a ValueSource. But it contains a lot of code pertaining to an area overlap similarity as a ValueSource (very cool stuff) but that isn't tested at all, and that's my only concern. If we want to be cautious about avoiding releasing untested code, then I suggest back-porting BBoxStrategy to 4x (pretty easy) but not the AreaSimilarity class. The reference to it in BBoxStrategy is the method makeBBoxAreaSimilarityValueSource() which can be commented out in 4x.
Sound good?
was (Author: dsmiley):
The BBoxStrategy is tested insofar as search filtering and returning the standard center-point distance as a ValueSource. But it contains a lot of code pertaining to an area overlap similarity as a ValueSource (very cool stuff) but that isn't tested at all, and that's my only concern. If we want to be cautious about avoiding releasing untested code, then I suggest back-porting BBoxStrategy to 4x (pretty easy) but not the AreaSimilarity class. The reference to it in BBoxStrategy is the method makeBBoxAreaSimilarityValueSource() which can be commented out in trunk.
Sound good?
> Include BBox Spatial Strategy
> -----------------------------
>
> Key: LUCENE-4175
> URL: https://issues.apache.org/jira/browse/LUCENE-4175
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Attachments: LUCENE-4175-bbox-strategy.patch
>
>
> This is an approach to indexing bounding boxes using 4 numeric fields (xmin,ymin,xmax,ymax) and a flag to say if it crosses the dateline.
> This is a modification from the Apache 2.0 code from the ESRI Geoportal:
> http://geoportal.svn.sourceforge.net/svnroot/geoportal/Geoportal/trunk/src/com/esri/gpt/catalog/lucene/SpatialClauseAdapter.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4175) Include BBox Spatial Strategy
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403039#comment-13403039 ]
Chris Male commented on LUCENE-4175:
------------------------------------
bq. I think we should ignore (remove?) 4.x for now... there will be some heavy committing in this area soon and keeping two branches is not very helpful.
what?
> Include BBox Spatial Strategy
> -----------------------------
>
> Key: LUCENE-4175
> URL: https://issues.apache.org/jira/browse/LUCENE-4175
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Attachments: LUCENE-4175-bbox-strategy.patch
>
>
> This is an approach to indexing bounding boxes using 4 numeric fields (xmin,ymin,xmax,ymax) and a flag to say if it crosses the dateline.
> This is a modification from the Apache 2.0 code from the ESRI Geoportal:
> http://geoportal.svn.sourceforge.net/svnroot/geoportal/Geoportal/trunk/src/com/esri/gpt/catalog/lucene/SpatialClauseAdapter.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4175) Include BBox Spatial Strategy
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402908#comment-13402908 ]
Ryan McKinley commented on LUCENE-4175:
---------------------------------------
I just added this to trunk in r1354841
I think we should ignore (remove?) 4.x for now... there will be some heavy committing in this area soon and keeping two branches is not very helpful.
I'll take a stab at how this could look with LUCENE-4167 (remove SpatialOperation)
> Include BBox Spatial Strategy
> -----------------------------
>
> Key: LUCENE-4175
> URL: https://issues.apache.org/jira/browse/LUCENE-4175
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Attachments: LUCENE-4175-bbox-strategy.patch
>
>
> This is an approach to indexing bounding boxes using 4 numeric fields (xmin,ymin,xmax,ymax) and a flag to say if it crosses the dateline.
> This is a modification from the Apache 2.0 code from the ESRI Geoportal:
> http://geoportal.svn.sourceforge.net/svnroot/geoportal/Geoportal/trunk/src/com/esri/gpt/catalog/lucene/SpatialClauseAdapter.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4175) Include BBox Spatial Strategy
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459341#comment-13459341 ]
Chris Male commented on LUCENE-4175:
------------------------------------
With the very near release of 4.0, I don't think we should backport anything untested. I also don't think we're in any immediate hurry for this since we've got other options in 4.0. But we should definitely work on the testing and push it for 4.1.
> Include BBox Spatial Strategy
> -----------------------------
>
> Key: LUCENE-4175
> URL: https://issues.apache.org/jira/browse/LUCENE-4175
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Attachments: LUCENE-4175-bbox-strategy.patch
>
>
> This is an approach to indexing bounding boxes using 4 numeric fields (xmin,ymin,xmax,ymax) and a flag to say if it crosses the dateline.
> This is a modification from the Apache 2.0 code from the ESRI Geoportal:
> http://geoportal.svn.sourceforge.net/svnroot/geoportal/Geoportal/trunk/src/com/esri/gpt/catalog/lucene/SpatialClauseAdapter.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4175) Include BBox Spatial Strategy
Posted by "David Smiley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458050#comment-13458050 ]
David Smiley commented on LUCENE-4175:
--------------------------------------
The BBoxStrategy is tested insofar as search filtering and returning the standard center-point distance as a ValueSource. But it contains a lot of code pertaining to an area overlap similarity as a ValueSource (very cool stuff) but that isn't tested at all, and that's my only concern. If we want to be cautious about avoiding releasing untested code, then I suggest back-porting BBoxStrategy to 4x (pretty easy) but not the AreaSimilarity class. The reference to it in BBoxStrategy is the method makeBBoxAreaSimilarityValueSource() which can be commented out in trunk.
Sound good?
> Include BBox Spatial Strategy
> -----------------------------
>
> Key: LUCENE-4175
> URL: https://issues.apache.org/jira/browse/LUCENE-4175
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Attachments: LUCENE-4175-bbox-strategy.patch
>
>
> This is an approach to indexing bounding boxes using 4 numeric fields (xmin,ymin,xmax,ymax) and a flag to say if it crosses the dateline.
> This is a modification from the Apache 2.0 code from the ESRI Geoportal:
> http://geoportal.svn.sourceforge.net/svnroot/geoportal/Geoportal/trunk/src/com/esri/gpt/catalog/lucene/SpatialClauseAdapter.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-4175) Include BBox Spatial Strategy
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley resolved LUCENE-4175.
-----------------------------------
Resolution: Fixed
> Include BBox Spatial Strategy
> -----------------------------
>
> Key: LUCENE-4175
> URL: https://issues.apache.org/jira/browse/LUCENE-4175
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Attachments: LUCENE-4175-bbox-strategy.patch
>
>
> This is an approach to indexing bounding boxes using 4 numeric fields (xmin,ymin,xmax,ymax) and a flag to say if it crosses the dateline.
> This is a modification from the Apache 2.0 code from the ESRI Geoportal:
> http://geoportal.svn.sourceforge.net/svnroot/geoportal/Geoportal/trunk/src/com/esri/gpt/catalog/lucene/SpatialClauseAdapter.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4175) Include BBox Spatial Strategy
Posted by "David Smiley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403350#comment-13403350 ]
David Smiley commented on LUCENE-4175:
--------------------------------------
Cool!
Perhaps the (small) infrastructure changes to SpatialTestCase & StrategyTestCase should be done to 4x. (an aside: Doing development against two branches is a pain. I'm glad I don't deal with this overhead for any other projects)
> Include BBox Spatial Strategy
> -----------------------------
>
> Key: LUCENE-4175
> URL: https://issues.apache.org/jira/browse/LUCENE-4175
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Attachments: LUCENE-4175-bbox-strategy.patch
>
>
> This is an approach to indexing bounding boxes using 4 numeric fields (xmin,ymin,xmax,ymax) and a flag to say if it crosses the dateline.
> This is a modification from the Apache 2.0 code from the ESRI Geoportal:
> http://geoportal.svn.sourceforge.net/svnroot/geoportal/Geoportal/trunk/src/com/esri/gpt/catalog/lucene/SpatialClauseAdapter.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4175) Include BBox Spatial Strategy
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley updated LUCENE-4175:
----------------------------------
Attachment: LUCENE-4175-bbox-strategy.patch
Here is a BBox strategy with some simple tests that touch each of the supported operations.
This also passes all the other (weak) spatial tests
> Include BBox Spatial Strategy
> -----------------------------
>
> Key: LUCENE-4175
> URL: https://issues.apache.org/jira/browse/LUCENE-4175
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Attachments: LUCENE-4175-bbox-strategy.patch
>
>
> This is an approach to indexing bounding boxes using 4 numeric fields (xmin,ymin,xmax,ymax) and a flag to say if it crosses the dateline.
> This is a modification from the Apache 2.0 code from the ESRI Geoportal:
> http://geoportal.svn.sourceforge.net/svnroot/geoportal/Geoportal/trunk/src/com/esri/gpt/catalog/lucene/SpatialClauseAdapter.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4175) Include BBox Spatial Strategy
Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403182#comment-13403182 ]
Steven Rowe commented on LUCENE-4175:
-------------------------------------
Ryan,
Jenkins builds are failing. e.g. [http://jenkins.sd-datasolutions.de/job/Lucene-Solr-trunk-Linux-Java6-64/1082/], as a result of a missing package javadocs file for {{org.apache.lucene.spatial.bbox}}:
{noformat}
javadocs-lint:
[exec]
[exec] Crawl/parse...
...
[exec]
[exec] Verify...
[exec]
[exec] build/docs/spatial/overview-summary.html
[exec] missing: org.apache.lucene.spatial.bbox
[exec]
[exec] Missing javadocs were found!
{noformat}
> Include BBox Spatial Strategy
> -----------------------------
>
> Key: LUCENE-4175
> URL: https://issues.apache.org/jira/browse/LUCENE-4175
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Attachments: LUCENE-4175-bbox-strategy.patch
>
>
> This is an approach to indexing bounding boxes using 4 numeric fields (xmin,ymin,xmax,ymax) and a flag to say if it crosses the dateline.
> This is a modification from the Apache 2.0 code from the ESRI Geoportal:
> http://geoportal.svn.sourceforge.net/svnroot/geoportal/Geoportal/trunk/src/com/esri/gpt/catalog/lucene/SpatialClauseAdapter.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4175) Include BBox Spatial Strategy
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457938#comment-13457938 ]
Robert Muir commented on LUCENE-4175:
-------------------------------------
Is it still by intention that this is not backported to 4.x? I just want to be sure.
> Include BBox Spatial Strategy
> -----------------------------
>
> Key: LUCENE-4175
> URL: https://issues.apache.org/jira/browse/LUCENE-4175
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Attachments: LUCENE-4175-bbox-strategy.patch
>
>
> This is an approach to indexing bounding boxes using 4 numeric fields (xmin,ymin,xmax,ymax) and a flag to say if it crosses the dateline.
> This is a modification from the Apache 2.0 code from the ESRI Geoportal:
> http://geoportal.svn.sourceforge.net/svnroot/geoportal/Geoportal/trunk/src/com/esri/gpt/catalog/lucene/SpatialClauseAdapter.java
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org