[GitHub] kumarvishal09 commented on a change in pull request #3096: [CARBONDATA-3267]Fixed Range Sort OOM Issue

[GitBox <gi...@apache.org>]

kumarvishal09 commented on a change in pull request #3096: [CARBONDATA-3267]Fixed Range Sort OOM Issue 
URL: https://github.com/apache/carbondata/pull/3096#discussion_r250266119
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/loading/sort/impl/UnsafeParallelReadMergeSorterImpl.java
 ##########
 @@ -85,7 +85,9 @@ public UnsafeParallelReadMergeSorterImpl(AtomicLong rowCounter) {
     } catch (Exception e) {
       throw new CarbonDataLoadingException(e);
     }
-    this.executorService = Executors.newFixedThreadPool(iterators.length,
+    // setting the number of cores to 1 in case of range sort
+    int numberOfCores = sortParameters.isRangeSort() ? 1 : iterators.length;
 
 Review comment:
   updated code removed isRangeSort from sort parameter as sort iterators length was always one

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services