You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by sa...@apache.org on 2014/02/10 21:55:13 UTC
svn commit: r1566741 -
/lucene/dev/trunk/solr/core/src/test/org/apache/solr/CursorPagingTest.java
Author: sarowe
Date: Mon Feb 10 20:55:12 2014
New Revision: 1566741
URL: http://svn.apache.org/r1566741
Log:
SOLR-5652: in cursor tests, don't sort on 'plain' docvalue fields (i.e., those using standard Lucene sorting for missing values) when the codec doesn't support missing docvalues.
Modified:
lucene/dev/trunk/solr/core/src/test/org/apache/solr/CursorPagingTest.java
Modified: lucene/dev/trunk/solr/core/src/test/org/apache/solr/CursorPagingTest.java
URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/test/org/apache/solr/CursorPagingTest.java?rev=1566741&r1=1566740&r2=1566741&view=diff
==============================================================================
--- lucene/dev/trunk/solr/core/src/test/org/apache/solr/CursorPagingTest.java (original)
+++ lucene/dev/trunk/solr/core/src/test/org/apache/solr/CursorPagingTest.java Mon Feb 10 20:55:12 2014
@@ -634,21 +634,24 @@ public class CursorPagingTest extends So
* </p>
* <ul>
* <li><code>_version_</code> is removed</li>
- * <li><code>dv_last</code> and <code>dv_first</code> fields are removed
- * if the codec doesn't support them</li>
+ * <li>
+ * <code>*_dv_last</code>, <code>*_dv_first</code> and <code>*_dv</code>
+ * fields are removed if the codec doesn't support missing DocValues
+ * </li>
* </ul>
* @see #defaultCodecSupportsMissingDocValues
*/
public static List<String> pruneAndDeterministicallySort(Collection<String> raw) {
- final boolean prune_dv_missing = ! defaultCodecSupportsMissingDocValues();
+ final boolean prune_dv = ! defaultCodecSupportsMissingDocValues();
ArrayList<String> names = new ArrayList<String>(37);
for (String f : raw) {
if (f.equals("_version_")) {
continue;
}
- if (prune_dv_missing && (f.endsWith("_dv_last") || f.endsWith("_dv_first")) ) {
+ if (prune_dv && (f.endsWith("_dv_last") || f.endsWith("_dv_first"))
+ || f.endsWith("_dv")) {
continue;
}
names.add(f);