[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1582: MINIFICPP-2128 - Verify thirdparty test utility hash

["fgerlits (via GitHub)" <gi...@apache.org>]

fgerlits commented on code in PR #1582:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1582#discussion_r1221397601


##########
.github/workflows/ci.yml:
##########
@@ -84,6 +84,7 @@ jobs:
       - id: install-sqliteodbc-driver
         run: |
           Invoke-WebRequest -Uri "http://www.ch-werner.de/sqliteodbc/sqliteodbc_w64.exe" -OutFile "sqliteodbc_w64.exe"
+          if ((Get-FileHash 'sqliteodbc_w64.exe').Hash -ne "bd93e8450bcbd4ae16894e06ecb1b8572d6a01448df5b8dd2964eb6d3d302db7") {Fail "Hash mismatch"}

Review Comment:
   This works, but it's a bit unorthodox to use the non-existent keyword "Fail" to generate a syntax error in order to stop the CI job.  Would `Write "Hash mismatch"; Exit 1` work?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org