[GitHub] [geode] mivanac opened pull request #4505: GEODE-7414_1: Define interface

["mivanac (GitHub)" <gi...@apache.org>]

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [*] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [*] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [*] Is your initial contribution a single, squashed commit?

- [*] Does `gradlew build` run cleanly?

- [*] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4505 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] lgtm-com[bot] commented on issue #4505: GEODE-7414_1: Define interface

[lg...@gitbox.apache.org]

This pull request **introduces 1 alert** when merging dae49cdf698f90cbdcff6756f263bc1b09076330 into ceea971a808aa3e88be4e9034018d10108e5ea14 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-35047f4740a7ed4b74b246ef5a8d0cc6439ed920)

**new alerts:**

* 1 for Spurious Javadoc @param tags

[ Full content available at: https://github.com/apache/geode/pull/4505 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mivanac commented on issue #4505: GEODE-7414_1: Define interface

["mivanac (GitHub)" <gi...@apache.org>]

We wanted to implement this SSL extension, similar to SecurityManager implementation. And we are expecting just one implementation to be executed.

[ Full content available at: https://github.com/apache/geode/pull/4505 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mivanac commented on pull request #4505: GEODE-7414_1: Define interface

["mivanac (GitHub)" <gi...@apache.org>]

Thanks for comments

[ Full content available at: https://github.com/apache/geode/pull/4505 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] mivanac commented on pull request #4505: GEODE-7414_1: Define interface

["mivanac (GitHub)" <gi...@apache.org>]

Thanks for comments

[ Full content available at: https://github.com/apache/geode/pull/4505 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal commented on pull request #4505: GEODE-7414_1: Define interface

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

Just a minor nit, but I think most new tests are using the AssertJ style for assertions. In this case that would be:
```
    assertThat(sslSocket.getSSLParameters().getServerNames()).isEqualTo(serverNames);
```

[ Full content available at: https://github.com/apache/geode/pull/4505 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal commented on pull request #4505: GEODE-7414_1: Define interface

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

You probably meant `SSLParameterExtension` instead of `SecurityManager`?

[ Full content available at: https://github.com/apache/geode/pull/4505 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal commented on pull request #4505: GEODE-7414_1: Define interface

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

Since this will be a public API it should not be in an `internal` package. I'd suggest using `org.apache.geode.net`.

[ Full content available at: https://github.com/apache/geode/pull/4505 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org