[GitHub] [systemds] Baunsgaard commented on a change in pull request #1154: [SYSTEMDS-2550] Parameter Server Validation and FedParamServ Statistics

[GitBox <gi...@apache.org>]

Baunsgaard commented on a change in pull request #1154:
URL: https://github.com/apache/systemds/pull/1154#discussion_r558057320



##########
File path: src/main/java/org/apache/sysds/runtime/controlprogram/paramserv/ParamServer.java
##########
@@ -119,7 +175,7 @@ public ListObject getResult() {
 		// so we could return directly the result model
 		return _model;
 	}
-	
+
 	protected synchronized void updateGlobalModel(int workerID, ListObject gradients) {
 		try {
 			if (LOG.isDebugEnabled()) {

Review comment:
       everything is surrounded by a is debug enabled witch is a lower level than info.

##########
File path: src/main/java/org/apache/sysds/runtime/controlprogram/paramserv/ParamServer.java
##########
@@ -154,6 +222,20 @@ protected synchronized void updateGlobalModel(int workerID, ListObject gradients
 				}
 				case ASP: {
 					updateGlobalModel(gradients);
+					if(LOG.isInfoEnabled()) {
+						// This if works similarly to the one for BSP, but divides the sync couter through the number of workers,
+						// creating "Pseudo Epochs"
+						if (LOG.isInfoEnabled() && _validationPossible &&

Review comment:
       outerif checks the same as first part of inner if.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org