You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by sjcorbett <gi...@git.apache.org> on 2016/11/15 14:18:52 UTC

[GitHub] brooklyn-library pull request #75: ZooKeeper ensemble fixes

GitHub user sjcorbett opened a pull request:

    https://github.com/apache/brooklyn-library/pull/75

    ZooKeeper ensemble fixes

    * Fixes ZooKeeper ensembles by ensuring that each node has a different id. 
    * Improves live tests to test that data can be written and read back.
    * ZooKeeperNodes publish their host and port on main.uri
    * ZooKeeperEnsemble aggregates its member's main.uris into a list and combines them into a comma-separated string at `zookeeper.endpoints`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sjcorbett/brooklyn-library zookeeper-ensemble

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-library/pull/75.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #75
    
----
commit 0a26e56d680a940155737ef6bddfa04b0566179c
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date:   2016-11-08T18:59:20Z

    Add javax.ws.rs-api dependency to software/messaging in test scope

commit 1d6738a6fe64cfd9db3c91de40cba24fde1d756c
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date:   2016-11-14T18:35:54Z

    ZooKeeper tests: assert data can be written and read back

commit 570683039e2f7188ea96eb7f5f284372db37230d
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date:   2016-11-15T10:40:38Z

    ZooKeeperNode ID is config rather than a sensor
    
    Defaults to 1. ZooKeeperEnsemble increments it on each member. This fixes
    communication between nodes.

commit bd9bbca7ed743871cb88ae6c185f48fec1658429
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date:   2016-11-15T13:06:34Z

    ZooKeeper nodes publish main.uri and ensembles aggregate to list

commit 287c7ab3d73e08424b358588c34ec48851403b3b
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date:   2016-11-15T13:07:00Z

    Exclude log4j-over-slf4j from storm dependency

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-library issue #75: ZooKeeper ensemble fixes

Posted by drigodwin <gi...@git.apache.org>.
Github user drigodwin commented on the issue:

    https://github.com/apache/brooklyn-library/pull/75
  
    Looks good & tested on AWS. We probably also need to extend the tests at [brooklyn-zookeeper-ensemble](https://github.com/brooklyncentral/brooklyn-zookeeper-ensemble/) at some point to better identify issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-library issue #75: ZooKeeper ensemble fixes

Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:

    https://github.com/apache/brooklyn-library/pull/75
  
    Thanks for reviewing and testing @drigodwin. Merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-library pull request #75: ZooKeeper ensemble fixes

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-library/pull/75


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-library issue #75: ZooKeeper ensemble fixes

Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the issue:

    https://github.com/apache/brooklyn-library/pull/75
  
    The build failed because it's missing the dependencies mentioned in brooklyn-server.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] brooklyn-library issue #75: ZooKeeper ensemble fixes

Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the issue:

    https://github.com/apache/brooklyn-library/pull/75
  
    These changes depend on https://github.com/apache/brooklyn-server/pull/439.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---