You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2019/02/22 10:15:33 UTC
[GitHub] jorgebay commented on a change in pull request #1065:
TINKERPOP-2161 - GraphBinary: use a single buffer instead of allocators
jorgebay commented on a change in pull request #1065: TINKERPOP-2161 - GraphBinary: use a single buffer instead of allocators
URL: https://github.com/apache/tinkerpop/pull/1065#discussion_r259283232
##########
File path: gremlin-driver/src/test/java/org/apache/tinkerpop/gremlin/driver/ser/binary/TypeSerializerFailureTests.java
##########
@@ -1,116 +1,116 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-package org.apache.tinkerpop.gremlin.driver.ser.binary;
-
-import io.netty.buffer.UnpooledByteBufAllocator;
-import org.apache.tinkerpop.gremlin.driver.ser.SerializationException;
-import org.apache.tinkerpop.gremlin.process.remote.traversal.DefaultRemoteTraverser;
-import org.apache.tinkerpop.gremlin.process.traversal.Bytecode;
-import org.apache.tinkerpop.gremlin.process.traversal.step.util.BulkSet;
-import org.apache.tinkerpop.gremlin.process.traversal.step.util.EmptyPath;
-import org.apache.tinkerpop.gremlin.process.traversal.step.util.Tree;
-import org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversalMetrics;
-import org.apache.tinkerpop.gremlin.process.traversal.util.MutableMetrics;
-import org.apache.tinkerpop.gremlin.structure.Vertex;
-import org.apache.tinkerpop.gremlin.structure.util.reference.ReferenceEdge;
-import org.apache.tinkerpop.gremlin.structure.util.reference.ReferencePath;
-import org.apache.tinkerpop.gremlin.structure.util.reference.ReferenceVertex;
-import org.apache.tinkerpop.gremlin.structure.util.reference.ReferenceVertexProperty;
-import org.apache.tinkerpop.gremlin.util.function.Lambda;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
-
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.Collections;
-import java.util.List;
-
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.fail;
-
-@RunWith(Parameterized.class)
-public class TypeSerializerFailureTests {
-
- private final GraphBinaryWriter writer = new GraphBinaryWriter();
- private final UnpooledByteBufAllocator allocator = new UnpooledByteBufAllocator(false);
-
- @Parameterized.Parameters(name = "Value={0}")
- public static Collection input() {
- final Bytecode.Binding b = new Bytecode.Binding(null, "b");
-
- final ReferenceVertex vertex = new ReferenceVertex("a vertex", null);
-
- final Bytecode bytecode = new Bytecode();
- bytecode.addStep(null);
-
- final BulkSet<Object> bulkSet = new BulkSet<>();
- bulkSet.add(vertex, 1L);
-
- final MutableMetrics metrics = new MutableMetrics("a metric", null);
-
- final Tree<Vertex> tree = new Tree<>();
- tree.put(vertex, null);
-
- // Provide instances that are malformed for serialization to fail
- return Arrays.asList(
- b,
- vertex,
- Collections.singletonMap("one", b),
- bulkSet,
- bytecode,
- Collections.singletonList(vertex),
- new ReferenceEdge("an edge", null, vertex, vertex),
- Lambda.supplier(null),
- metrics,
- new DefaultTraversalMetrics(1L, Collections.singletonList(metrics)),
- new DefaultRemoteTraverser<>(new Object(), 1L),
- tree,
- new ReferenceVertexProperty<>("a prop", null, "value"),
- new InvalidPath()
- );
- }
-
- @Parameterized.Parameter(value = 0)
- public Object value;
-
- @Test
- public void shouldReleaseMemoryWhenFails() {
- try {
- writer.write(value, allocator);
- fail("Should throw exception");
- } catch (SerializationException | RuntimeException e) {
- // Do nothing
- }
-
- assertEquals(0, allocator.metric().usedHeapMemory());
- }
-
- public static class InvalidPath extends ReferencePath {
- public InvalidPath() {
- super(EmptyPath.instance());
- }
-
- @Override
- public List<Object> objects() {
- return Collections.singletonList(new Object());
- }
- }
-}
+///*
+// * Licensed to the Apache Software Foundation (ASF) under one
+// * or more contributor license agreements. See the NOTICE file
+// * distributed with this work for additional information
+// * regarding copyright ownership. The ASF licenses this file
+// * to you under the Apache License, Version 2.0 (the
+// * "License"); you may not use this file except in compliance
+// * with the License. You may obtain a copy of the License at
+// *
+// * http://www.apache.org/licenses/LICENSE-2.0
+// *
+// * Unless required by applicable law or agreed to in writing,
+// * software distributed under the License is distributed on an
+// * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// * KIND, either express or implied. See the License for the
+// * specific language governing permissions and limitations
+// * under the License.
+// */
+//
+//package org.apache.tinkerpop.gremlin.driver.ser.binary;
+//
+//import io.netty.buffer.UnpooledByteBufAllocator;
+//import org.apache.tinkerpop.gremlin.driver.ser.SerializationException;
+//import org.apache.tinkerpop.gremlin.process.remote.traversal.DefaultRemoteTraverser;
+//import org.apache.tinkerpop.gremlin.process.traversal.Bytecode;
+//import org.apache.tinkerpop.gremlin.process.traversal.step.util.BulkSet;
+//import org.apache.tinkerpop.gremlin.process.traversal.step.util.EmptyPath;
+//import org.apache.tinkerpop.gremlin.process.traversal.step.util.Tree;
+//import org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversalMetrics;
+//import org.apache.tinkerpop.gremlin.process.traversal.util.MutableMetrics;
+//import org.apache.tinkerpop.gremlin.structure.Vertex;
+//import org.apache.tinkerpop.gremlin.structure.util.reference.ReferenceEdge;
+//import org.apache.tinkerpop.gremlin.structure.util.reference.ReferencePath;
+//import org.apache.tinkerpop.gremlin.structure.util.reference.ReferenceVertex;
+//import org.apache.tinkerpop.gremlin.structure.util.reference.ReferenceVertexProperty;
+//import org.apache.tinkerpop.gremlin.util.function.Lambda;
+//import org.junit.Test;
+//import org.junit.runner.RunWith;
+//import org.junit.runners.Parameterized;
+//
+//import java.util.Arrays;
+//import java.util.Collection;
+//import java.util.Collections;
+//import java.util.List;
+//
+//import static org.junit.Assert.assertEquals;
+//import static org.junit.Assert.fail;
+//
+//@RunWith(Parameterized.class)
+//public class TypeSerializerFailureTests {
Review comment:
oh, good catch!
I'll fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services