You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org> on 2011/03/25 20:36:05 UTC
[jira] [Created] (FELIX-2892) Get SCR annotations to work with
Scala
Get SCR annotations to work with Scala
--------------------------------------
Key: FELIX-2892
URL: https://issues.apache.org/jira/browse/FELIX-2892
Project: Felix
Issue Type: Improvement
Components: Maven SCR Plugin
Reporter: Reto Bachmann-Gmür
Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler resolved FELIX-2892.
-------------------------------------
Resolution: Fixed
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
> Assignee: Carsten Ziegeler
> Fix For: maven-scr-plugin-1.8.2
>
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510399#comment-13510399 ]
Carsten Ziegeler commented on FELIX-2892:
-----------------------------------------
Yes, as Arjun wrote, this is a bug in scala
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
> Assignee: Carsten Ziegeler
> Fix For: maven-scr-plugin-1.9.0
>
> Attachments: Foo.class
>
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507395#comment-13507395 ]
Carsten Ziegeler commented on FELIX-2892:
-----------------------------------------
I've deployed the snapshots and plan to cut a release next week.
I'm not sure why you get these imports in your case, this doesn't happen when used with Java - the annotations have retention policy of class, so bnd shouldn't see them
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
> Assignee: Carsten Ziegeler
> Fix For: maven-scr-plugin-1.8.2
>
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469438#comment-13469438 ]
Carsten Ziegeler commented on FELIX-2892:
-----------------------------------------
I finally found FELIX-509, which is the issue why we added include/exclude patterns - basically it boils down to bugs in QDox which we are not using anymore
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Jochen Fliedner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451938#comment-13451938 ]
Jochen Fliedner commented on FELIX-2892:
----------------------------------------
The problem is this preceeding identification of the information kept in the Source objects collection. This is done on the - or an aggregation of? - source folder(s) using "project.getCompileSourceRoots().iterator()".
Class names are identified and in that some assumptions are hardcoded that are feasable only for Java sources:
- that the eventual classes fqns always corresponds with the folder structure and the file name of the sources
- that there is a "java" file extension
When locally in the code i switch to "project.getBuild().getOutputDirectory()" and assume a file extension of length 5 - like in ".class" - to be tossed, it basically works fine. So obviously you can always use such assumptions at the output dir with its folder structure and class files.
Especially with Scala there are some regarding problems like you can code multiple packages and types within one source file, but after compilation that should be fine.
Generally it would not be necessary to have any source folders involved for the nature of the thing that is to be accomplished here, even when it adheres to maven best practices to do so.
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507358#comment-13507358 ]
Reto Bachmann-Gmür commented on FELIX-2892:
-------------------------------------------
I tried it with maven-bundle-plugin 2.3.7 and maven-scr-plugin 1.8.1-SNAPSHOT compiled from trunk, but no OSGI-INF is in the the target jar. Should I use other versions?
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
> Assignee: Carsten Ziegeler
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045341#comment-13045341 ]
Carsten Ziegeler commented on FELIX-2892:
-----------------------------------------
The annotations are only needed at build time - that's why they just have source for the scope.
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451999#comment-13451999 ]
Carsten Ziegeler commented on FELIX-2892:
-----------------------------------------
Processing class files is one thing, but being able to relate an error to the source is the other important feature. That's why we have this Source object which a) points to a source file and b) points to a class file to process.
We can change the process how these source objects are constructred in any way, however we need a pointer to the source file.
I guess it would be interesting in the scala case to get an error reported on the scala source as well.
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510388#comment-13510388 ]
Reto Bachmann-Gmür commented on FELIX-2892:
-------------------------------------------
The error message occurs when I request a service by an interface defined in Scala. So it seems that these annotations have somehow become part of the interface.
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
> Assignee: Carsten Ziegeler
> Fix For: maven-scr-plugin-1.9.0
>
> Attachments: Foo.class
>
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510436#comment-13510436 ]
Reto Bachmann-Gmür commented on FELIX-2892:
-------------------------------------------
The problem with the import statements can be worked around with the Ignore-Pacakge directive. The problem with the service can be worked around by extracting the exposed interface to a trait or superclass that has no annotation.
E.g. for the example above define a trait FooT with the bar method and expose this as service interface:
@Component
@Service(Array(classOf[FooT]))
class Foo extends FooT {
...
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
> Assignee: Carsten Ziegeler
> Fix For: maven-scr-plugin-1.9.0
>
> Attachments: Foo.class
>
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507382#comment-13507382 ]
Carsten Ziegeler commented on FELIX-2892:
-----------------------------------------
Thanks for testing!
No, excluding the annotations is the right thing - especially as there is no bundle containing these classes.
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
> Assignee: Carsten Ziegeler
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466665#comment-13466665 ]
Carsten Ziegeler commented on FELIX-2892:
-----------------------------------------
Ok, how about this:
Instead of scanning just the source tree, we scan both, source tree and class files. If we know the source, we create a source object with source and class file, if we just have a class, we create a source file with an "unknown" source object.
Obviously this slows down the build process, so it would be nice if we could have some trigger for also scanning the classes directory. We could either make this configurable and have it off by default, or check for src/main/scala and/or src/main/scripts or something like that.
WDYT?
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Arjun Panday (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508867#comment-13508867 ]
Arjun Panday commented on FELIX-2892:
-------------------------------------
for info, i'd filed a bug to scala a while ago about this issue:
https://issues.scala-lang.org/browse/SI-4788
The problem is the scala compiler retaining all annotations at runtime .
I think bnd takes this into account and automatically adds
Ignore-Package: aQute.bnd.annotation.component
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
> Assignee: Carsten Ziegeler
> Fix For: maven-scr-plugin-1.8.2
>
> Attachments: Foo.class
>
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler reassigned FELIX-2892:
---------------------------------------
Assignee: Carsten Ziegeler
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
> Assignee: Carsten Ziegeler
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Jochen Fliedner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450533#comment-13450533 ]
Jochen Fliedner commented on FELIX-2892:
----------------------------------------
As of FELIX-3550 and version "maven-scr-plugin-1.8.0" etc. there is class retention and also ASM is used to extract the annotations from class files. As a problem for Scala remains that in a first step the maven plugin identifies the types from the project source folders *.java files. There is no java source code generated by the Scala compiler, so you won´t see any action.
Btw some groovy guys seem happy already and switched their servlet from Java code to an annoted Groovy type: https://github.com/Citytechinc/cq5-groovy-console
I think they let generate Java stubs by the "gmaven-plugin" and those can be used by the scr plugin.
Would it be possible to make the class identifiction run on the maven project target folder?
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (FELIX-2892) Get SCR annotations to work
with Scala
Posted by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507358#comment-13507358 ]
Reto Bachmann-Gmür edited comment on FELIX-2892 at 11/30/12 3:18 PM:
---------------------------------------------------------------------
Great with <scanClasses>true</scanClasses> it works. The only thing I had to exclude the scr-annotation in the bundle plugin with <Import-Package>!org.apache.felix.scr.annotations, *</Import-Package>, or would there be a reason fro having the available in OSGi.
was (Author: reto):
I tried it with maven-bundle-plugin 2.3.7 and maven-scr-plugin 1.8.1-SNAPSHOT compiled from trunk, but no OSGI-INF is in the the target jar. Should I use other versions?
Update: it seems to work when I put the <scanClasses>true</scanClasses> in the rightplace
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
> Assignee: Carsten Ziegeler
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045342#comment-13045342 ]
Carsten Ziegeler commented on FELIX-2892:
-----------------------------------------
Maybe you could explain this use case a little bit more ?
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503881#comment-13503881 ]
Carsten Ziegeler commented on FELIX-2892:
-----------------------------------------
Added a new configuration
<scanClasses>true</scanClasses>
If this is set, the classes folder is searched instead.
Please give it a try
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
> Assignee: Carsten Ziegeler
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507388#comment-13507388 ]
Reto Bachmann-Gmür commented on FELIX-2892:
-------------------------------------------
Could you deploy the snapshot to the snapshot repository? And of course having a release soon would be great.
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
> Assignee: Carsten Ziegeler
> Fix For: maven-scr-plugin-1.8.2
>
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508675#comment-13508675 ]
Carsten Ziegeler commented on FELIX-2892:
-----------------------------------------
Not sure who is giving out this message, however the released version of the annotations (1.7.0) are using class as the retention policy, so they are not loaded/required for usual Java applications.
Maybe the scala runtime is doing something?
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
> Assignee: Carsten Ziegeler
> Fix For: maven-scr-plugin-1.8.2
>
> Attachments: Foo.class
>
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451280#comment-13451280 ]
Carsten Ziegeler commented on FELIX-2892:
-----------------------------------------
Actually the scanning is done in the target classes folder: the maven scr plugin feeds a list of Source objects into the generator, a source object contains a file object pointing to the source (so this would be the java or the scala file) and the class name. This class name is used to find the class using a class loader which includes the target/classes folder.
So I think all we have to do, is to instruct the maven scr plugin to create source objects for scala source files and the class which is generated.
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Reto Bachmann-Gmür updated FELIX-2892:
--------------------------------------
Attachment: Foo.class
I'm having problems also at runtime, I'm getting the error:
zz>val t = $[Foo]
error: error while loading Foo, Missing dependency 'class org.apache.felix.scr.annotations.Component', required by org/apache/clerezza/jaxrs/stanbol/webfragements/Foo.class
Foo.class is attached, Foo.scala looks as follows:
package org.apache.clerezza.jaxrs.stanbol.webfragements
import org.apache.felix.scr.annotations._
@Component
@Service
class Foo {
println("fooling")
def bar() {
var r = getClass.getResource("META-INF/MANIFEST.MF")
println(r)
}
}
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
> Assignee: Carsten Ziegeler
> Fix For: maven-scr-plugin-1.8.2
>
> Attachments: Foo.class
>
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler updated FELIX-2892:
------------------------------------
Fix Version/s: maven-scr-plugin-1.8.2
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
> Assignee: Carsten Ziegeler
> Fix For: maven-scr-plugin-1.8.2
>
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Reto Bachmann-Gmür (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158520#comment-13158520 ]
Reto Bachmann-Gmür commented on FELIX-2892:
-------------------------------------------
If the retention level is CLASS and the bind-methods are added in bytecode any language that runs on the jvm would be supported by the scr plugin. They would not be available at runtime.
For a discussion see: http://mail-archives.apache.org/mod_mbox/felix-users/201011.mbox/%3CAANLkTikGW_9fjDt1dfPuOTWR9fQ50_XB7TBf3-3Z0Djf@mail.gmail.com%3E
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (FELIX-2892) Get SCR annotations to work with
Scala
Posted by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507389#comment-13507389 ]
Reto Bachmann-Gmür commented on FELIX-2892:
-------------------------------------------
Can something be done to avoid having to exclude it manually?
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
> Assignee: Carsten Ziegeler
> Fix For: maven-scr-plugin-1.8.2
>
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (FELIX-2892) Get SCR annotations to work
with Scala
Posted by "Reto Bachmann-Gmür (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-2892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507358#comment-13507358 ]
Reto Bachmann-Gmür edited comment on FELIX-2892 at 11/30/12 3:09 PM:
---------------------------------------------------------------------
I tried it with maven-bundle-plugin 2.3.7 and maven-scr-plugin 1.8.1-SNAPSHOT compiled from trunk, but no OSGI-INF is in the the target jar. Should I use other versions?
Update: it seems to work when I put the <scanClasses>true</scanClasses> in the rightplace
was (Author: reto):
I tried it with maven-bundle-plugin 2.3.7 and maven-scr-plugin 1.8.1-SNAPSHOT compiled from trunk, but no OSGI-INF is in the the target jar. Should I use other versions?
> Get SCR annotations to work with Scala
> --------------------------------------
>
> Key: FELIX-2892
> URL: https://issues.apache.org/jira/browse/FELIX-2892
> Project: Felix
> Issue Type: Improvement
> Components: Maven SCR Plugin
> Reporter: Reto Bachmann-Gmür
> Assignee: Carsten Ziegeler
>
> Currently the maven scr plugin doesn't work with scala, teh main reason for this is that the annotation have only source scope and the adding of bind-methods happe on a source rather than a bytecode level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira