You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2020/12/07 03:30:58 UTC
[GitHub] [struts] JCgH4164838Gh792C124B5 opened a new pull request #454: WW-5093 - Improve tag var attribute comments.
JCgH4164838Gh792C124B5 opened a new pull request #454:
URL: https://github.com/apache/struts/pull/454
- Minor non-code changes, driven by examination of the issue.
- Update taglib version from 2.3 to 2.6
- Apply missing @ Override annotation to methods in several components.
- ContextBean - tag attribute description updated to mention scope action.
- ServletUrlRenderer - corrected code comment concerning scope of var
attribute, corrected spelling mistake, changed URL case.
- Set - Added JavaDoc and code comment to clarify that with action scope
the var is also assigned to page scope. Updated tag descriptions for var
and scope to further clarify the behaviour.
- Text - Added JavaDoc comment to clarify that if the var attribute is used
the result is not written out, but instead saved into the action context.
- AttributeMap - Whitespace cleanup in get() method, plus added @ Override
tags to multiple methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts] JCgH4164838Gh792C124B5 commented on pull request #454: WW-5093 - Improve tag var attribute comments.
Posted by GitBox <gi...@apache.org>.
JCgH4164838Gh792C124B5 commented on pull request #454:
URL: https://github.com/apache/struts/pull/454#issuecomment-739643788
Hello Apache Struts Team.
Please let me know if you see any errors in the updated information/comments for the var attribute of the tags (or anything else in the PR).
If the updates make sense, we could check the site documentation and see about adding any relevant changes there as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] coveralls commented on pull request #454: WW-5093 - Improve tag var attribute comments.
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #454:
URL: https://github.com/apache/struts/pull/454#issuecomment-739652759
[](https://coveralls.io/builds/35489566)
Coverage remained the same at 49.78% when pulling **3a7c35a014f8a3471a1b75e7546e01ecf21d5db3 on JCgH4164838Gh792C124B5:local_WW-5093_improvement** into **2739ceaab405a4216cdc3c92b5f951b9d0ea099d on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] lukaszlenart merged pull request #454: WW-5093 - Improve tag var attribute comments.
Posted by GitBox <gi...@apache.org>.
lukaszlenart merged pull request #454:
URL: https://github.com/apache/struts/pull/454
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts] lukaszlenart commented on a change in pull request #454: WW-5093 - Improve tag var attribute comments.
Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on a change in pull request #454:
URL: https://github.com/apache/struts/pull/454#discussion_r537255967
##########
File path: core/pom.xml
##########
@@ -31,7 +31,7 @@
<name>Struts 2 Core</name>
<properties>
- <tlib.version>2.3</tlib.version>
+ <tlib.version>2.6</tlib.version>
Review comment:
👏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org