You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/07 03:20:57 UTC
[GitHub] [iotdb] chengjianyun opened a new pull request #3920: [cluster-refactor] refactor client pool
chengjianyun opened a new pull request #3920:
URL: https://github.com/apache/iotdb/pull/3920
Closed the https://github.com/apache/iotdb/pull/3886 to merge and resolve conflicts.
The main idea of the refactor:
- Apply `Apache commons pool` replace ourself implementation.
- Remove unnecessary classes.
- Add new class `ClientManager` to help manage client instances instead of letting user get client from pool directly.
The PR will contain:
- [x] keep the interface unchanged as much as possible
- [x] Close client means close the connection after refactor.
- [x] replace `ClientPool` with `KeyedObjectPool` in Apache Commons Pool
- [x] fix the test cases error
- [ ] self test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] chengjianyun closed pull request #3920: [cluster-refactor] refactor client pool
Posted by GitBox <gi...@apache.org>.
chengjianyun closed pull request #3920:
URL: https://github.com/apache/iotdb/pull/3920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #3920: [cluster-refactor] refactor client pool
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3920:
URL: https://github.com/apache/iotdb/pull/3920#issuecomment-913975537
[](https://coveralls.io/builds/42687783)
Coverage decreased (-0.006%) to 67.488% when pulling **a1ec9f323ea40a253b12b5c4655d32c331b9c39b on chengjianyun:refactor/client-pool2** into **2400c36179229c55364539632f2fcc3212ac6bed on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org