You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/04/27 11:46:52 UTC
[GitHub] [incubator-echarts] wf123537200 opened a new pull request #12508: Add husky
wf123537200 opened a new pull request #12508:
URL: https://github.com/apache/incubator-echarts/pull/12508
## Brief Information
because i pull request without run ```npm run lint```, and the ide is not warned me, so i add husky to make sure the eslint has been check before commit.
This pull request is in the type of:
- [ ] bug fixing
- [ ] new feature
- [x] others
### What does this PR do?
add husky and pre-commit task to keep the code style consistent
### Fixed issues
## Details
### Before: What was the problem?
may commit a pr without check the code style
### After: How is it fixed in this PR?
the commit will interrupt by the git-hook (husky)
## Usage
### Are there any API changes?
- [ ] The API has been changed.
### Related test cases or examples to use the new APIs
NA.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merge.
### Other information
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #12508: Add husky
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #12508:
URL: https://github.com/apache/incubator-echarts/pull/12508#issuecomment-620948468
Thanks! It seems this PR also includes the content in your earlier PR https://github.com/apache/incubator-echarts/pull/12487. Can you separate it so we can merge this PR ASAP
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] susiwen8 commented on pull request #12508: Add husky
Posted by GitBox <gi...@apache.org>.
susiwen8 commented on pull request #12508:
URL: https://github.com/apache/incubator-echarts/pull/12508#issuecomment-619933192
Thanks, That's very useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] wf123537200 commented on pull request #12508: Add husky
Posted by GitBox <gi...@apache.org>.
wf123537200 commented on pull request #12508:
URL: https://github.com/apache/incubator-echarts/pull/12508#issuecomment-620957398
Hi~~The husky is already separated, i think the last commit at PR #12487 not includes the husky, i use ```npm run lint``` to keep the code style. So this PR can be merge alone
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on pull request #12508: Add husky
Posted by GitBox <gi...@apache.org>.
pissang commented on pull request #12508:
URL: https://github.com/apache/incubator-echarts/pull/12508#issuecomment-620962839
Hi, the changed files in this PR shows the change in https://github.com/apache/incubator-echarts/pull/12487 is also included. I think husky in this PR can be merged alone when we are still discussing https://github.com/apache/incubator-echarts/pull/12487.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on pull request #12508: Add husky
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #12508:
URL: https://github.com/apache/incubator-echarts/pull/12508#issuecomment-619931330
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/incubator-echarts/wiki/How-to-make-a-pull-request).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org