You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/16 07:27:18 UTC
[GitHub] [apisix] bin-ya opened a new pull request #6627: docs: modify the make install in how to build Apache APISIX doc
bin-ya opened a new pull request #6627:
URL: https://github.com/apache/apisix/pull/6627
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes: #6559
### Checklist
- [x] I have explained the need for this PR and the problem it solves
- [x] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [x] I have updated the documentation to reflect this change
- [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #6627: docs: modify the make install in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #6627:
URL: https://github.com/apache/apisix/pull/6627#discussion_r830718533
##########
File path: docs/en/latest/how-to-build.md
##########
@@ -125,7 +125,7 @@ Follow the steps below to install Apache APISIX via the source release package.
cd apisix-${APISIX_VERSION}
# Create dependencies
make deps
- # Install apisix command
+ # Install apisix command (only for luarocks)
make install
Review comment:
@bin-ya I think `Install apisix command (only for luarocks)` should be changed to `Install apisix command (developer do not need to follow this step)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6627: docs: modify the make install in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6627:
URL: https://github.com/apache/apisix/pull/6627#discussion_r830605387
##########
File path: docs/en/latest/how-to-build.md
##########
@@ -125,7 +125,7 @@ Follow the steps below to install Apache APISIX via the source release package.
cd apisix-${APISIX_VERSION}
# Create dependencies
make deps
- # Install apisix command
+ # Install apisix command (only for luarocks)
make install
Review comment:
Yes. We can rename this task and claim that the developer should not try to "install" the source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6627: docs: modify the make install in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6627:
URL: https://github.com/apache/apisix/pull/6627#discussion_r830776573
##########
File path: docs/en/latest/how-to-build.md
##########
@@ -125,7 +125,7 @@ Follow the steps below to install Apache APISIX via the source release package.
cd apisix-${APISIX_VERSION}
# Create dependencies
make deps
- # Install apisix command
+ # Install apisix command (developer do not need to follow this step)
Review comment:
I am confused. If it is no need, why not remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6627: docs: modify the make install in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #6627:
URL: https://github.com/apache/apisix/pull/6627
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bin-ya commented on a change in pull request #6627: docs: modify the make install in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
bin-ya commented on a change in pull request #6627:
URL: https://github.com/apache/apisix/pull/6627#discussion_r830718683
##########
File path: docs/en/latest/how-to-build.md
##########
@@ -125,7 +125,7 @@ Follow the steps below to install Apache APISIX via the source release package.
cd apisix-${APISIX_VERSION}
# Create dependencies
make deps
- # Install apisix command
+ # Install apisix command (only for luarocks)
make install
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #6627: docs: modify the make install in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #6627:
URL: https://github.com/apache/apisix/pull/6627#discussion_r829680658
##########
File path: docs/en/latest/how-to-build.md
##########
@@ -125,7 +125,7 @@ Follow the steps below to install Apache APISIX via the source release package.
cd apisix-${APISIX_VERSION}
# Create dependencies
make deps
- # Install apisix command
+ # Install apisix command (only for luarocks)
make install
Review comment:
rm `make install` is better?
##########
File path: docs/en/latest/how-to-build.md
##########
@@ -125,7 +125,7 @@ Follow the steps below to install Apache APISIX via the source release package.
cd apisix-${APISIX_VERSION}
# Create dependencies
make deps
- # Install apisix command
+ # Install apisix command (only for luarocks)
make install
Review comment:
cc @spacewander
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #6627: docs: modify the make install in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #6627:
URL: https://github.com/apache/apisix/pull/6627#discussion_r830834457
##########
File path: docs/en/latest/how-to-build.md
##########
@@ -125,7 +125,7 @@ Follow the steps below to install Apache APISIX via the source release package.
cd apisix-${APISIX_VERSION}
# Create dependencies
make deps
- # Install apisix command
+ # Install apisix command (developer do not need to follow this step)
Review comment:
let's remove it. cc @bin-ya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #6627: docs: modify the make install in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #6627:
URL: https://github.com/apache/apisix/pull/6627#discussion_r829680658
##########
File path: docs/en/latest/how-to-build.md
##########
@@ -125,7 +125,7 @@ Follow the steps below to install Apache APISIX via the source release package.
cd apisix-${APISIX_VERSION}
# Create dependencies
make deps
- # Install apisix command
+ # Install apisix command (only for luarocks)
make install
Review comment:
rm `make install` is better?
##########
File path: docs/en/latest/how-to-build.md
##########
@@ -125,7 +125,7 @@ Follow the steps below to install Apache APISIX via the source release package.
cd apisix-${APISIX_VERSION}
# Create dependencies
make deps
- # Install apisix command
+ # Install apisix command (only for luarocks)
make install
Review comment:
cc @spacewander
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bin-ya commented on a change in pull request #6627: docs: modify the make install in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
bin-ya commented on a change in pull request #6627:
URL: https://github.com/apache/apisix/pull/6627#discussion_r831677031
##########
File path: docs/en/latest/how-to-build.md
##########
@@ -125,8 +125,6 @@ Follow the steps below to install Apache APISIX via the source release package.
cd apisix-${APISIX_VERSION}
# Create dependencies
make deps
- # Install apisix command
- make install
Review comment:
Sorry for my mistake, I'll change it immediately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bin-ya commented on a change in pull request #6627: docs: modify the make install in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
bin-ya commented on a change in pull request #6627:
URL: https://github.com/apache/apisix/pull/6627#discussion_r831677031
##########
File path: docs/en/latest/how-to-build.md
##########
@@ -125,8 +125,6 @@ Follow the steps below to install Apache APISIX via the source release package.
cd apisix-${APISIX_VERSION}
# Create dependencies
make deps
- # Install apisix command
- make install
Review comment:
Sorry for my mistake, I'll change it immediately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #6627: docs: modify the make install in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #6627:
URL: https://github.com/apache/apisix/pull/6627#discussion_r831001912
##########
File path: docs/en/latest/how-to-build.md
##########
@@ -125,8 +125,6 @@ Follow the steps below to install Apache APISIX via the source release package.
cd apisix-${APISIX_VERSION}
# Create dependencies
make deps
- # Install apisix command
- make install
Review comment:
We can also remove `make uninstall`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org