You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/07 20:43:59 UTC
[GitHub] [pulsar] ravi-vaidyanathan opened a new pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup
ravi-vaidyanathan opened a new pull request #11957:
URL: https://github.com/apache/pulsar/pull/11957
### Motivation
Fix a few small issues found during testing and code inspection.
### Modifications
*Added missing check for permissions for certain ResourceGroup operations.
*Check if ResourceGroup exists before proceeding to update in pulsar-admin.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
- [ ] tested manually
### Documentation
- [ ] no-need-doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup
Posted by GitBox <gi...@apache.org>.
ravi-vaidyanathan commented on pull request #11957:
URL: https://github.com/apache/pulsar/pull/11957#issuecomment-914618283
@jerrypeng @cckellogg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup
Posted by GitBox <gi...@apache.org>.
ravi-vaidyanathan commented on pull request #11957:
URL: https://github.com/apache/pulsar/pull/11957#issuecomment-918596327
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup
Posted by GitBox <gi...@apache.org>.
ravi-vaidyanathan commented on pull request #11957:
URL: https://github.com/apache/pulsar/pull/11957#issuecomment-918528911
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup
Posted by GitBox <gi...@apache.org>.
ravi-vaidyanathan commented on pull request #11957:
URL: https://github.com/apache/pulsar/pull/11957#issuecomment-918459849
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup
Posted by GitBox <gi...@apache.org>.
ravi-vaidyanathan commented on pull request #11957:
URL: https://github.com/apache/pulsar/pull/11957#issuecomment-917759141
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup
Posted by GitBox <gi...@apache.org>.
ravi-vaidyanathan commented on pull request #11957:
URL: https://github.com/apache/pulsar/pull/11957#issuecomment-918299903
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup
Posted by GitBox <gi...@apache.org>.
ravi-vaidyanathan commented on pull request #11957:
URL: https://github.com/apache/pulsar/pull/11957#issuecomment-918160083
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup
Posted by GitBox <gi...@apache.org>.
ravi-vaidyanathan commented on pull request #11957:
URL: https://github.com/apache/pulsar/pull/11957#issuecomment-917714418
> We should add a test to ensure that there are not future regressions.
@michaeljmarshall you are right, so added unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup
Posted by GitBox <gi...@apache.org>.
ravi-vaidyanathan commented on pull request #11957:
URL: https://github.com/apache/pulsar/pull/11957#issuecomment-917714162
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup
Posted by GitBox <gi...@apache.org>.
ravi-vaidyanathan commented on pull request #11957:
URL: https://github.com/apache/pulsar/pull/11957#issuecomment-917723662
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup
Posted by GitBox <gi...@apache.org>.
ravi-vaidyanathan commented on pull request #11957:
URL: https://github.com/apache/pulsar/pull/11957#issuecomment-918145622
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aahmed-se merged pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup
Posted by GitBox <gi...@apache.org>.
aahmed-se merged pull request #11957:
URL: https://github.com/apache/pulsar/pull/11957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup
Posted by GitBox <gi...@apache.org>.
ravi-vaidyanathan commented on pull request #11957:
URL: https://github.com/apache/pulsar/pull/11957#issuecomment-914680790
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup
Posted by GitBox <gi...@apache.org>.
ravi-vaidyanathan commented on pull request #11957:
URL: https://github.com/apache/pulsar/pull/11957#issuecomment-918635894
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup
Posted by GitBox <gi...@apache.org>.
ravi-vaidyanathan commented on pull request #11957:
URL: https://github.com/apache/pulsar/pull/11957#issuecomment-914820313
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup
Posted by GitBox <gi...@apache.org>.
ravi-vaidyanathan commented on pull request #11957:
URL: https://github.com/apache/pulsar/pull/11957#issuecomment-914861962
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup
Posted by GitBox <gi...@apache.org>.
ravi-vaidyanathan commented on pull request #11957:
URL: https://github.com/apache/pulsar/pull/11957#issuecomment-914649916
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup
Posted by GitBox <gi...@apache.org>.
ravi-vaidyanathan commented on pull request #11957:
URL: https://github.com/apache/pulsar/pull/11957#issuecomment-917781917
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ravi-vaidyanathan edited a comment on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup
Posted by GitBox <gi...@apache.org>.
ravi-vaidyanathan edited a comment on pull request #11957:
URL: https://github.com/apache/pulsar/pull/11957#issuecomment-917714418
> We should add a test to ensure that there are not future regressions.
@michaeljmarshall you are right, added unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] bharanic-dev commented on pull request #11957: [PIP-82] [pulsar-broker] Add missing permission check, fail update on non-existent ResourceGroup
Posted by GitBox <gi...@apache.org>.
bharanic-dev commented on pull request #11957:
URL: https://github.com/apache/pulsar/pull/11957#issuecomment-918661549
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org