[GitHub] [maven-release] nielsbasjes commented on pull request #104: [MRELEASE-1078] Conventional commits

[GitBox <gi...@apache.org>]

nielsbasjes commented on PR #104:
URL: https://github.com/apache/maven-release/pull/104#issuecomment-1145882140

   I take the clean master branch and only change in the main pom.xml
   
   -    <scmVersion>1.13.0</scmVersion>
   +    <scmVersion>2.0.0-M2-SNAPSHOT</scmVersion>
   
   Then I run `mvn clean verify`  (without the -Prun-its !!)
   
   Then the Maven Release Manager fails with a lot of errors (70 failures).
   I get the same results with both java 8, 11 and 17
   
   When looking through the errors I see these recurring ones:
   
   - DefaultScmRepositoryConfiguratorTest.testGetConfiguredRepository:72 check provider expected:<s[vn]> but was:<s[tub-provider]>
   - Expected text value 'release-label' but was 'original-tag' 
   - Expected text value 'scm:svn:file://localhost/tmp/scm-repo/tags/release-label' but was 'scm:svn:file://localhost/tmp/scm-repo/trunk/' 
   - ClassCast class org.apache.maven.scm.provider.ScmProviderRepositoryStub cannot be cast to class org.apache.maven.scm.provider.ScmProviderRepositoryWithHost
   
   @michael-o Are these the failures you were referring to? 
   Are these caused by the scm change from 1.x to 2.x ? 
   I consider these errors something that should be fixed outside of this specific pull request. Do you agree?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org