You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by "casionone (via GitHub)" <gi...@apache.org> on 2023/03/09 04:21:16 UTC
[GitHub] [linkis] casionone commented on a diff in pull request #4064: [ISSUE-4063]The material package removes the version prefix 'v'
casionone commented on code in PR #4064:
URL: https://github.com/apache/linkis/pull/4064#discussion_r1130406640
##########
linkis-computation-governance/linkis-manager/linkis-application-manager/src/main/scala/org/apache/linkis/engineplugin/server/localize/DefaultEngineConnBmlResourceGenerator.scala:
##########
@@ -31,10 +33,16 @@ class DefaultEngineConnBmlResourceGenerator
override def generate(engineConnType: String): Map[String, Array[EngineConnLocalizeResource]] =
getEngineConnDistHomeList(engineConnType).map { path =>
- val distFile = new File(path)
- val key = if (distFile.getName.startsWith("v")) distFile.getName else NO_VERSION_MARK
+ val versionFile = new File(path)
Review Comment:
add log about path and enginetype info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org