[GitHub] jihoonson commented on a change in pull request #6780: Add support maxRowsPerSegment for auto compaction

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #6780: Add support maxRowsPerSegment for auto compaction
URL: https://github.com/apache/incubator-druid/pull/6780#discussion_r244832574
 
 

 ##########
 File path: indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskSerdeTest.java
 ##########
 @@ -116,23 +116,31 @@ public void testIndexTaskTuningConfigTargetPartitionSizeOrNumShards() throws Exc
         IndexTask.IndexTuningConfig.class
     );
 
-    Assert.assertEquals(10, (int) tuningConfig.getTargetPartitionSize());
+    Assert.assertEquals(10, (int) tuningConfig.getMaxRowsPerSegment());
 
 Review comment:
   Thanks. I added a test when both maxRowsPerSegment and targetPartitionSize don't exist. We already have a test for when only targetPartitionSize is provided [here](https://github.com/apache/incubator-druid/pull/6780/files#diff-be6c09b426aded436da657df0be06cffR154).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org