You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/22 22:01:44 UTC
[GitHub] [airflow] trowdan opened a new pull request #13852: check failed service before auto_remove it
trowdan opened a new pull request #13852:
URL: https://github.com/apache/airflow/pull/13852
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
Closes: https://github.com/apache/airflow/issues/13532
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13852: check failed service before auto_remove it
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13852:
URL: https://github.com/apache/airflow/pull/13852#issuecomment-766273779
Can you add tests to avoid regression?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13852: check failed service before auto_remove it
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13852:
URL: https://github.com/apache/airflow/pull/13852#issuecomment-770215691
[The Workflow run](https://github.com/apache/airflow/actions/runs/523384535) is cancelling this PR. Building image for the PR has been cancelled
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13852: check failed service before auto_remove it
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13852:
URL: https://github.com/apache/airflow/pull/13852#issuecomment-765709146
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] trowdan commented on pull request #13852: check failed service before auto_remove it
Posted by GitBox <gi...@apache.org>.
trowdan commented on pull request #13852:
URL: https://github.com/apache/airflow/pull/13852#issuecomment-770235111
> Can you also please add description @trowdan - with context - in the commit message. It's great to refer an inssue, but the commit messages have to be descriptive enough and provide enough context so that when you do `git log` you know what the change is about and why it was implmented. You can run `git log` and see examples of good descriptive messages there.
Sure Jarek,
I've squashed the commits and added a description. Let me now if it's ok now.
Note that this fixes the https://github.com/apache/airflow/issues/13532 for DockerSwarmOperator, that is affected by the same issue. I'll try to take a look into DockerOperator and eventually open a new PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13852: check failed service before auto_remove it
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13852:
URL: https://github.com/apache/airflow/pull/13852#issuecomment-770215598
[The Workflow run](https://github.com/apache/airflow/actions/runs/523434234) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13852: check failed service before auto_remove it
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13852:
URL: https://github.com/apache/airflow/pull/13852#issuecomment-770225652
Can you also please add description @trowdan - with context - in the commit message. It's great to refer an inssue, but the commit messages have to be descriptive enough and provide enough context so that when you do `git log` you know what the change is about and why it was implmented. You can run `git log` and see examples of good descriptive messages there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13852: check failed service before auto_remove it
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13852:
URL: https://github.com/apache/airflow/pull/13852#issuecomment-770245400
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13852: check failed service before auto_remove it
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13852:
URL: https://github.com/apache/airflow/pull/13852
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org