[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1726: [CELEBORN-804] ShuffleClient should cleanup shuffle infos when trigger unregisterShuffle.

["RexXiong (via GitHub)" <gi...@apache.org>]

RexXiong commented on code in PR #1726:
URL: https://github.com/apache/incubator-celeborn/pull/1726#discussion_r1267686020


##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -616,7 +611,7 @@ class LifecycleManager(val appUniqueId: String, val conf: CelebornConf) extends
     reply(mapperAttemptFinishedSuccess)
   }
 
-  def handleUnregisterShuffle(
+  def unregisterShuffle(
       shuffleId: Int): Unit = {
     if (getPartitionType(shuffleId) == PartitionType.REDUCE) {

Review Comment:
   Yes, It's required for Flink to clean Flink Job related infos, especially in session mode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org