You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2020/08/29 20:05:17 UTC

Review Request 72818: RANGER-2979: fix for NPE in unit-test

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72818/
-----------------------------------------------------------

Review request for ranger, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2979
    https://issues.apache.org/jira/browse/RANGER-2979


Repository: ranger


Description
-------

updated RangerHiveAuthorizer to gracefully handle null return from getUserRoles()


Diffs
-----

  hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java e54f93a8f 


Diff: https://reviews.apache.org/r/72818/diff/1/


Testing
-------

mvn verify package complated successfully, without hitting NPE


Thanks,

Madhan Neethiraj


Re: Review Request 72818: RANGER-2979: fix for NPE in unit-test

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72818/#review221749
-----------------------------------------------------------


Ship it!




Ship It!

- Ramesh Mani


On Aug. 29, 2020, 8:05 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72818/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2020, 8:05 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2979
>     https://issues.apache.org/jira/browse/RANGER-2979
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> updated RangerHiveAuthorizer to gracefully handle null return from getUserRoles()
> 
> 
> Diffs
> -----
> 
>   hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java e54f93a8f 
> 
> 
> Diff: https://reviews.apache.org/r/72818/diff/1/
> 
> 
> Testing
> -------
> 
> mvn verify package complated successfully, without hitting NPE
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>


Re: Review Request 72818: RANGER-2979: fix for NPE in unit-test

Posted by Mehul Parikh <xs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72818/#review221753
-----------------------------------------------------------


Ship it!




Ship It!

- Mehul Parikh


On Aug. 29, 2020, 8:05 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72818/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2020, 8:05 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2979
>     https://issues.apache.org/jira/browse/RANGER-2979
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> updated RangerHiveAuthorizer to gracefully handle null return from getUserRoles()
> 
> 
> Diffs
> -----
> 
>   hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java e54f93a8f 
> 
> 
> Diff: https://reviews.apache.org/r/72818/diff/1/
> 
> 
> Testing
> -------
> 
> mvn verify package complated successfully, without hitting NPE
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>