You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/04/30 10:47:35 UTC

[GitHub] [incubator-ratis] runzhiwang opened a new pull request #78: RATIS-833. Add metrics for raft log cache count and size in bytes

runzhiwang opened a new pull request #78:
URL: https://github.com/apache/incubator-ratis/pull/78


   @bshashikant Could you help review it ? Thank you very much.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] runzhiwang commented on pull request #78: RATIS-833. Add metrics for raft log cache count and size in bytes

Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #78:
URL: https://github.com/apache/incubator-ratis/pull/78#issuecomment-637458501


   @bshashikant updated


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] bshashikant merged pull request #78: RATIS-833. Add metrics for raft log cache count and size in bytes

Posted by GitBox <gi...@apache.org>.
bshashikant merged pull request #78:
URL: https://github.com/apache/incubator-ratis/pull/78


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] bshashikant commented on pull request #78: RATIS-833. Add metrics for raft log cache count and size in bytes

Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #78:
URL: https://github.com/apache/incubator-ratis/pull/78#issuecomment-623528556


   Thanks @runzhiwang for working on this. We can potentially large no of closed segments in ratis pipeline lifecycle if log purging is not enabled. I am just thinking if it would be better to maintain the total segment size in memory instead of iterating over all to figure the size every-time to fetch the metric value. What do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] bshashikant commented on pull request #78: RATIS-833. Add metrics for raft log cache count and size in bytes

Posted by GitBox <gi...@apache.org>.
bshashikant commented on pull request #78:
URL: https://github.com/apache/incubator-ratis/pull/78#issuecomment-637411092


   @runzhiwang , can you please update the PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org